-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor remaining tests that instantiate QueryManager
directly and remove mockQueryManager
helper
#12327
Merged
Merged
Refactor remaining tests that instantiate QueryManager
directly and remove mockQueryManager
helper
#12327
Changes from 1 commit
Commits
Show all changes
97 commits
Select commit
Hold shift + click to select a range
16bfbd6
Add toEmitFetchResult matcher
jerelmiller 9e18a16
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller a235468
Use toEmitFetchResult where appropriate
jerelmiller d43ba3b
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 63c890a
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 67789ca
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller d9f2ac8
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 49a07cd
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller e38549a
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 4dc9949
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 7bd78e3
Remove unused imports
jerelmiller 8d054c4
Use ObservableStream to test error for subscriptions
jerelmiller c890972
Use ObservableStream for subscriptions test
jerelmiller d3e11dc
Inline result to simulateResult
jerelmiller 3b626e3
Use ObservableStream for subscription test
jerelmiller 590953b
Use ObservableStream to test subscription
jerelmiller 647f290
USe ObservableStream to test subscription
jerelmiller 9531ae1
Use ObsservableStream to test subscription
jerelmiller 1fb04e7
Check for emitted value
jerelmiller fcb13cd
Use ObservableStream to test subscription
jerelmiller 78d76c5
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller a0bd1e0
Use toEmitApolloQueryResult
jerelmiller 3232105
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller b0fe67b
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 94f5d31
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 9243671
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 363f4a3
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 8656ccd
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 0146f6b
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller dfef74e
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller d379a73
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller add7bec
Fix test to match test description
jerelmiller 4d23938
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller c31b18e
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 68cf0dc
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller eff2515
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 5f1a891
Add todo comment
jerelmiller e4c9121
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 9264d97
Remove duplicate check
jerelmiller b250f06
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 876b002
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 7362158
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller dc45cdd
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller f783c84
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 2023245
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller f72ea2c
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 1f5619d
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 730f3de
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller f84ef7d
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller d24dfbc
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 60db597
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller da2cd63
Use custom matchers to test for full query result
jerelmiller 2efa813
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 27f018c
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller f78e186
Remove outdated comment
jerelmiller 01be76d
Use custom matchers
jerelmiller 5a3ecf8
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller eec859a
Inline link
jerelmiller 0faca17
Use custom matchers
jerelmiller e9e0201
Use custom matchers
jerelmiller 9e39df5
Add todo comments
jerelmiller e9f5109
Use custom matchers
jerelmiller 4c04d6f
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller ee4d9b6
Use custom matchers
jerelmiller 561f619
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 1851614
Use custom matchers
jerelmiller ce65dad
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller dcc3a87
Use custom matchers
jerelmiller 510622f
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 6fd20f6
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 1c43ca3
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller dbdd72c
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller d3be98a
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 509992f
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 13dd441
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller e323133
Use custom matchers
jerelmiller 27fe12a
Add clarifying comment
jerelmiller 18b90d1
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 6d3b07e
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 98f5273
Use MockLink directly
jerelmiller 4381582
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 74eef4d
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller be9c166
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 454887d
Use custom matchers
jerelmiller 6432625
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller dd892bf
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller c49a472
Use custom matchers
jerelmiller 1700cf7
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 62a7994
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 7acc2d2
Remove unused import
jerelmiller 75a80bd
Add todo comment
jerelmiller 17d7c98
Remove unused mockWatchQuery
jerelmiller ea37430
Replace instantiation of QueryManager with instantiation of ApolloClient
jerelmiller 5b05edf
Use custom matchers in local state tests
jerelmiller f74292f
Remove outdated comment
jerelmiller 955af26
Remove mockQueryManager
jerelmiller 7d8883d
Fix typo
jerelmiller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Replace instantiation of QueryManager with instantiation of ApolloClient
- Loading branch information
commit 94f5d31dc17539311a8693986c2c24e7d8481e1a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once these tests are pulled in the v4 branch, these should be fixed by the updated behavior of
cache.diff
.