Refactor remaining tests that instantiate QueryManager directly and remove mockQueryManager helper
#12327
Conversation
|
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 8c21210bcdb72a675c871898 |
There was a problem hiding this comment.
These are no longer needed since the tests that compared against these snapshots now check against an ApolloError instance directly.
commit: |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
| const { data, loading } = await stream.takeNext(); | ||
| await expect(stream).toEmitApolloQueryResult({ | ||
| // TODO: Ensure this value is undefined instead of an empty object | ||
| data: {}, |
There was a problem hiding this comment.
Once these tests are pulled in the v4 branch, these should be fixed by the updated behavior of cache.diff.
| const result = await stream.takeNext(); | ||
| await expect(stream).toEmitApolloQueryResult({ | ||
| // TODO: Fix this error | ||
| // @ts-expect-error `ApolloQueryResult` needs to be updated to allow for `undefined` and this value needs to emit undefined instead of empty object |
There was a problem hiding this comment.
This refactor exposed several issues with the values we emit at runtime vs the ApolloQueryResult type. This is something that will be addressed in v4.
Refactors the remaining tests that instantiated a
QueryManagerinstance directly to instantiate anApolloClientinstance instead. This makes our tests resemble more of the end-user experience. As a result, themockQueryManagerandmockWatchQueryhelpers were removed as they are no longer used.This PR also updates as many matchers as possible to use
to*ApolloQueryResultto ensure results match the expected values. This revealed several issues with our existing values emitted from the core API that don't match our TypeScript types. This will be corrected in the v4 release.