176 remove log config #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofu-rocketry
force-pushed
the
176-remove-log-config
branch
2 times, most recently
from
0b4ac74 to
76c15b7
Compare
tofu-rocketry
requested changes
Aug 1, 2022
Remove separate logging file functionality as it's not generally used and causes issues when accidentally included.
tofu-rocketry
force-pushed
the
176-remove-log-config
branch
from
224070a to
0f5a043
Compare
Add a warning, so that if the user provides a path for the logging config file (or a file exists at the old delfault path), the user is warned that the functionality has been deprecated.
tofu-rocketry
force-pushed
the
176-remove-log-config
branch
from
0f5a043 to
f149b8b
Compare
Ypick 7549342 Remove empty line Usage of os was removed when separate logging config was removed.
tofu-rocketry
force-pushed
the
176-remove-log-config
branch
from
7c2053c to
78bcd72
Compare
tofu-rocketry
approved these changes
Dec 12, 2022
gregcorbett
reviewed
Dec 12, 2022
Will-Cross1
added a commit
to Will-Cross1/apel
that referenced
this pull request
Sep 10, 2024
Remove separate logging file functionality as it's not generally used and causes issues when accidentally included. much the same as apel/ssm#176 issue and apel/ssm#203 PR
tofu-rocketry
pushed a commit
to apel/apel
that referenced
this pull request
Sep 12, 2024
Remove separate logging file functionality as it's not generally used and causes issues when accidentally included. Much the same as apel/ssm#176 issue and apel/ssm#203 PR - Removed log_config_file and replaced with options.log_config where used - Removed log_config_file uses in tests as they no longer are used by functions in the tested files - Removed (optional) from the help messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #176