Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate separate log config #176

Closed
tofu-rocketry opened this issue Aug 16, 2021 · 2 comments · Fixed by #203
Closed

Deprecate separate log config #176

tofu-rocketry opened this issue Aug 16, 2021 · 2 comments · Fixed by #203
Assignees
@Letizia97
Labels
bug GGUS Has a related GGUS ticket good first issue Good for newcomers
Milestone
3.3.0

Comments

@tofu-rocketry
Copy link
Member

logging.cfg causes a number of problems, not least that it doesn't seem to work and gives unexpected results if it's included without realising it. We should deprecate it and any related functionality (at least part of logging_helper and how it's handled in the executables).
@tofu-rocketry
Copy link
Member Author

tofu-rocketry commented Aug 24, 2021 •
edited
Loading

Also needed for APEL?

EDIT: Yes -> apel/apel#293

@tofu-rocketry tofu-rocketry added good first issue Good for newcomers and removed question labels Jul 21, 2022
@tofu-rocketry tofu-rocketry changed the title Deprecate log config Deprecate separate log config Jul 21, 2022
@tofu-rocketry
Copy link
Member Author

Issue with logging.cp came up in this GGUS ticket.

@tofu-rocketry tofu-rocketry added GGUS Has a related GGUS ticket bug and removed enhancement labels Jul 22, 2022
@Letizia97 Letizia97 mentioned this issue Jul 22, 2022
Merged
@tofu-rocketry tofu-rocketry added this to the 3.3.0 milestone Dec 12, 2022
Will-Cross1 added a commit to Will-Cross1/apel that referenced this issue Sep 10, 2024
@Will-Cross1
Deprecate separate logging config file
2448678 
Remove separate logging file functionality as it's not generally used
and causes issues when accidentally included.

much the same as apel/ssm#176 issue and apel/ssm#203 PR
@Will-Cross1 Will-Cross1 mentioned this issue Sep 11, 2024
Merged
tofu-rocketry pushed a commit to apel/apel that referenced this issue Sep 12, 2024
@Will-Cross1
Deprecate separate logging config file (#381)
6977feb 
Remove separate logging file functionality as it's not generally used
and causes issues when accidentally included.

Much the same as apel/ssm#176 issue and apel/ssm#203 PR

- Removed log_config_file and replaced with options.log_config where used
- Removed log_config_file uses in tests as they no longer are used by functions in the tested files
- Removed (optional) from the help messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Letizia97 Letizia97

Labels
bug GGUS Has a related GGUS ticket good first issue Good for newcomers
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

176 remove log config Letizia97/ssm
2 participants
@tofu-rocketry @Letizia97