Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing DeclarationSorter #777

Merged
merged 10 commits into from
Apr 28, 2021
Merged

Fixing DeclarationSorter #777

merged 10 commits into from
Apr 28, 2021

Conversation

konnov
Copy link
Collaborator

@konnov konnov commented Apr 28, 2021

This PR fixes two bugs in the declaration sorter. Closes #758 and #645.

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entry added to UNRELEASED.md for any new functionality

Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, tho my opinion hasn't changed about the error messages. But not something I'd want to block on. 👍

@konnov konnov merged commit fff113b into unstable Apr 28, 2021
@konnov konnov deleted the igor/bug758 branch April 28, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Type annotations in MC_*.tla files
2 participants