Fixing DeclarationSorter (#777)

* better messages in the type checker * closes #758: fixed missing edges in the dependency graph * entry in unreleased * closes #645: fixed a false cycle that, caused by a parameter having the same name as an operator * entry in UNRELEASED * Update tla-types/src/main/scala/at/forsyte/apalache/tla/typecheck/etc/EtcTypeChecker.scala Co-authored-by: Shon Feder <[email protected]> * Update tla-types/src/main/scala/at/forsyte/apalache/tla/typecheck/etc/EtcTypeChecker.scala Co-authored-by: Shon Feder <[email protected]> * fixed the error message Co-authored-by: Shon Feder <[email protected]>
apalache-mc · Apr 28, 2021 · fff113b · fff113b
1 parent f69fc72
commit fff113b
Show file tree

Hide file tree

Showing 4 changed files with 81 additions and 14 deletions.
diff --git a/UNRELEASED.md b/UNRELEASED.md
@@ -24,6 +24,7 @@
 * Parser: supporting annotations in multiline comments, see #718
 * Parser: supporting TLA+ identifiers in annotations, see #768
 * Parser: better parser for annotations, see #757
+* Parser: fixed two bugs in the declaration sorter, see #645 and #758
 * The command `config --enable-stats=true` creates `$HOME/.tlaplus` if needed, see #762
 
 ### Changes

diff --git a/tla-types/src/main/scala/at/forsyte/apalache/tla/typecheck/etc/EtcTypeChecker.scala b/tla-types/src/main/scala/at/forsyte/apalache/tla/typecheck/etc/EtcTypeChecker.scala
@@ -92,7 +92,7 @@ class EtcTypeChecker(varPool: TypeVarPool, inferPolytypes: Boolean = false) exte
             computeRec(ctx, solver, mkConst(ex.sourceRef, knownType))
           }
         } else {
-          onTypeError(ex.sourceRef, s"Undefined name $name. Introduce a type annotation.")
+          onTypeError(ex.sourceRef, s"No annotation found for $name. Make sure that you've put one in front of $name.")
           throw new UnwindException
         }
 
@@ -170,7 +170,7 @@ class EtcTypeChecker(varPool: TypeVarPool, inferPolytypes: Boolean = false) exte
           onTypeFound(name.sourceRef, nameType)
           computeRec(ctx, solver, mkApp(ex.sourceRef, Seq(nameType), args: _*))
         } else {
-          onTypeError(ex.sourceRef, s"Undefined operator name $name. Introduce a type annotation.")
+          onTypeError(ex.sourceRef, s"The operator $name is used before it is defined.")
           throw new UnwindException
         }
 

diff --git a/...c/main/scala/at/forsyte/apalache/tla/lir/transformations/standard/DeclarationSorter.scala b/...c/main/scala/at/forsyte/apalache/tla/lir/transformations/standard/DeclarationSorter.scala
@@ -1,10 +1,12 @@
 package at.forsyte.apalache.tla.lir.transformations.standard
 
-import at.forsyte.apalache.tla.lir.transformations.TlaModuleTransformation
 import at.forsyte.apalache.tla.lir._
 import at.forsyte.apalache.tla.lir.oper.TlaOper
+import at.forsyte.apalache.tla.lir.transformations.TlaModuleTransformation
 import at.forsyte.apalache.tla.lir.transformations.impl.StableTopologicalSort
+import com.typesafe.scalalogging.LazyLogging
 
+import java.io.{FileWriter, PrintWriter}
 import scala.collection.immutable.HashMap
 
 /**
@@ -19,12 +21,13 @@ import scala.collection.immutable.HashMap
  *
  * @author Igor Konnov
  */
-class DeclarationSorter extends TlaModuleTransformation {
+class DeclarationSorter extends TlaModuleTransformation with LazyLogging {
   type Edges = Map[UID, Set[UID]]
+  type MapIdToDecl = Map[UID, TlaDecl]
 
   override def apply(input: TlaModule): TlaModule = {
     // save the original order of the declarations
-    val idToDecl: Map[UID, TlaDecl] = input.declarations.foldLeft(Map.empty[UID, TlaDecl]) { case (map, d) =>
+    val idToDecl: MapIdToDecl = input.declarations.foldLeft(Map.empty[UID, TlaDecl]) { case (map, d) =>
       map + (d.ID -> d)
     }
 
@@ -38,13 +41,46 @@ class DeclarationSorter extends TlaModuleTransformation {
         sorted.map(idToDecl)
 
       case Right(witnesses) =>
+        val filename = explainCyclicDependency(idToDecl, depsGraph, witnesses)
+        logger.error(s"Check the dependency graph in $filename. You can view it with graphviz.")
         val opers = witnesses.map(idToDecl).map(_.name).mkString(", ")
         throw new CyclicDependencyError("Found a cyclic dependency among operators: " + opers)
     }
 
     new TlaModule(input.name, sortedDeclarations)
   }
 
+  // Dump the dependency graph to a dot file. Otherwise, it is very hard to see what is going on.
+  private def explainCyclicDependency(idToDecl: MapIdToDecl, depsGraph: Edges, witnesses: Set[UID]): String = {
+    val filename = "dependencies.dot"
+
+    def getName(uid: UID): String = {
+      idToDecl.get(uid).map(_.name).getOrElse("undefined")
+    }
+
+    def printToDot(writer: PrintWriter): Unit = {
+      writer.println("digraph dependencies {")
+
+      for (fromId <- witnesses) {
+        writer.println("""  n%s[label="%s"];""".format(fromId, getName(fromId)))
+        for (toId <- depsGraph.getOrElse(fromId, Set.empty)) {
+          if (witnesses.contains(toId)) {
+            writer.println("""  n%s -> n%s;""".format(fromId, toId))
+          }
+        }
+      }
+      writer.println("}")
+    }
+
+    val writer = new PrintWriter(new FileWriter(filename, false))
+    try {
+      printToDot(writer)
+      filename
+    } finally {
+      writer.close()
+    }
+  }
+
   // For every declaration ID id1, compute the list of distinct ID of the declarations that must be defined before id1
   private def computeDependenciesGraph(declarations: Seq[TlaDecl]): Edges = {
     // create a map from declaration names to their IDs
@@ -56,7 +92,6 @@ class DeclarationSorter extends TlaModuleTransformation {
       map + (defId -> (map(defId) ++ uses))
     }
 
-    val findUses = findExprUses(nameToId)
     // create a map that contains the list of used-by IDs for every declaration, excluding the declaration itself
     val initMap = Map(declarations.map { d => d.ID -> Set.empty[UID] }: _*)
     declarations.foldLeft(initMap) {
@@ -67,11 +102,13 @@ class DeclarationSorter extends TlaModuleTransformation {
         map + (d.ID -> Set.empty[UID])
 
       case (map, d @ TlaAssumeDecl(body)) =>
-        val uses = (findUses(body) - d.ID)
+        val uses = findExprUses(nameToId)(body) - d.ID
         updateDependencies(map, d.ID, uses)
 
-      case (map, d @ TlaOperDecl(_, _, body)) =>
-        val uses = (findUses(body) - d.ID)
+      case (map, d @ TlaOperDecl(_, params, body)) =>
+        // the operator parameters may shadow the name of  top-level operator, so we have to exclude parameter names
+        val nameToIdWithoutParams = nameToId -- params.map(_.name)
+        val uses = findExprUses(nameToIdWithoutParams)(body) - d.ID
         updateDependencies(map, d.ID, uses)
 
       case (map, _) => map
@@ -86,10 +123,14 @@ class DeclarationSorter extends TlaModuleTransformation {
         // A singleton with the id, if the name is registered; otherwise, empty set.
         nameToId.get(name).fold(Set.empty[UID])(Set(_))
 
-      case OperEx(TlaOper.apply, NameEx(name), _*) =>
+      case OperEx(TlaOper.apply, NameEx(name), args @ _*) =>
         // This may be an application of a user-defined operator.
-        // A singleton with the id, if the name is registered; otherwise, empty set.
-        nameToId.get(name).fold(Set.empty[UID])(Set(_))
+        // A singleton with the id, if the name is registered
+        //   (that is, for a top-level definition); otherwise, return the empty set (that is, for a LET-IN).
+        val base = nameToId.get(name).map(Set(_)).getOrElse(Set.empty)
+        args.foldLeft(base) { (u, arg) =>
+          u ++ usesRec(arg)
+        }
 
       case OperEx(_, args @ _*) =>
         // join the uses of the arguments
@@ -98,9 +139,12 @@ class DeclarationSorter extends TlaModuleTransformation {
         }
 
       case LetInEx(body, decls @ _*) =>
-        // join the uses of the body and the declarations
+        // Join the uses of the body and the declarations.
+        // We do not track dependencies between the LET-IN operators, because they are scoped and ordered.
         decls.foldLeft(usesRec(body)) { (u, d) =>
-          u ++ usesRec(d.body)
+          // the operator parameters may shadow the name of  top-level operator, so we have to exclude parameter names
+          val nameToIdWithoutParams = nameToId -- d.formalParams.map(_.name)
+          u ++ findExprUses(nameToIdWithoutParams)(d.body)
         }
 
       case _ =>

diff --git a/...st/scala/at/forsyte/apalache/tla/lir/transformations/standard/TestDeclarationSorter.scala b/...st/scala/at/forsyte/apalache/tla/lir/transformations/standard/TestDeclarationSorter.scala
@@ -44,6 +44,28 @@ class TestDeclarationSorter extends FunSuite with BeforeAndAfterEach {
     assertThrows[CyclicDependencyError](DeclarationSorter.instance(input))
   }
 
+  test("regression: a cycle hidden via a call") {
+    // regression for #758
+    val foo = tla.declOp("Foo", tla.int(1))
+    val bar = tla.declOp("Bar", tla.appOp(tla.name("Foo"), tla.appOp(tla.name("Baz"))))
+    val baz = tla.declOp("Baz", tla.appOp(tla.name("Foo"), tla.appOp(tla.name("Bar"))))
+    val input = new TlaModule("test", List(foo, bar, baz))
+    assertThrows[CyclicDependencyError](DeclarationSorter.instance(input))
+  }
+
+  test("regression: a false cycle") {
+    // regression for #645
+
+    // The following two declarations do not form a cycle, as Foo uses it's parameter 'pid', not calling the operator 'pid'.
+    // Foo(pid) == 1
+    val foo = tla.declOp("Foo", tla.name("pid"), OperParam("pid"))
+    // pid == Foo(2)
+    val pid = tla.declOp("pid", tla.appOp(tla.name("Foo"), tla.int(2)))
+    val input = new TlaModule("test", List(foo, pid))
+    val expected = new TlaModule("test", List(foo, pid))
+    assert(expected == DeclarationSorter.instance(input))
+  }
+
   test("Foo uses VARIABLE x out of order") {
     val foo = tla.declOp("Foo", tla.name("x"))
     val x = TlaVarDecl("x")