Add extra column to SavedQuery
#6687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
added
easy-review
risk:db-migration
| @@ -75,6 +75,9 @@ def pre_update(self, obj): | |||
|
|
|||
|
|
|||
| class SavedQueryViewApi(SavedQueryView): | |||
| list_columns = [ | |||
| 'label', 'sqlalchemy_uri', 'user_email', 'schema', 'description', | |||
There was a problem hiding this comment.
Do we need sqlalchemy_uri and user_email in the list view, how about the database name and user name in instead?
There was a problem hiding this comment.
Good question. The reason I'm exposing this is for Airflow, so it can schedule queries. In that case, having the email is better, since the username in our case comes from the Google auth. The SQLAlchemy URI also gives more info than just the DB name. But if you think it makes sense to return username and database name I can do the mapping in Airflow instead.
There was a problem hiding this comment.
Oh actually I didn't realized this is SavedQueryViewApi and not just SavedQueryView, it's totally good/fine to add it here. I thought this would affect the list view that users see...
bolkedebruin
suggested changes
Jan 15, 2019
superset/migrations/versions/a33a03f16c4a_add_extra_column_to_savedquery.py
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #6687 +/- ##
==========================================
- Coverage 56.22% 56.19% -0.03%
==========================================
Files 519 520 +1
Lines 23098 23186 +88
Branches 2759 2765 +6
==========================================
+ Hits 12986 13030 +44
- Misses 9702 9746 +44
Partials 410 410
Continue to review full report at Codecov.
|
kristw
added
enhancement:request
mistercrunch
approved these changes
Jan 18, 2019
betodealmeida
added
change:backend
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
* Expose more columns in saved queries API * Add extra column to SavedQuery * Add ASF header (cherry picked from commit 31ea681)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
* Expose more columns in saved queries API * Add extra column to SavedQuery * Add ASF header (cherry picked from commit 31ea681)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
* Expose more columns in saved queries API * Add extra column to SavedQuery * Add ASF header (cherry picked from commit 31ea681)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 31, 2019
* Expose more columns in saved queries API * Add extra column to SavedQuery * Add ASF header (cherry picked from commit 31ea681) (cherry picked from commit 764becaad6cf4d157c6fcba43a681d9768cf266b)
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #6112, this PR adds an
extracolumn toSavedQuery.Note that this PR depends on #6686, so the extra columns in the API are being shown here.