[SQL Lab] Allow running multiple statements #6112

mistercrunch · 2018-10-15T16:31:36Z

some refactoring to enable this

ghost · 2018-12-09T09:04:05Z

Please stop sending me emails and unsubscribe me

mistercrunch · 2018-12-09T19:21:40Z

@Putop you manage your own Github notifications, nothing we can do on this end.

codecov-io · 2018-12-19T07:10:53Z

Codecov Report

Merging #6112 into master will increase coverage by 0.1%.
The diff coverage is 85.71%.

@@            Coverage Diff            @@
##           master    #6112     +/-   ##
=========================================
+ Coverage   56.04%   56.14%   +0.1%     
=========================================
  Files         516      518      +2     
  Lines       22996    23044     +48     
  Branches     2819     2822      +3     
=========================================
+ Hits        12887    12939     +52     
+ Misses       9648     9644      -4     
  Partials      461      461

Impacted Files	Coverage Δ
superset/sql_parse.py	`99.2% <100%> (+0.05%)`	⬆️
superset/models/sql_lab.py	`98.46% <100%> (ø)`	⬆️
superset/utils/decorators.py	`100% <100%> (ø)`
...uperset/assets/src/SqlLab/components/ResultSet.jsx	`79.26% <100%> (+0.51%)`	⬆️
superset/security.py	`75.55% <100%> (ø)`	⬆️
superset/utils/core.py	`88.42% <100%> (-0.18%)`	⬇️
superset/assets/src/components/Loading.jsx	`100% <100%> (ø)`	⬆️
superset/utils/dates.py	`100% <100%> (ø)`
superset/db_engine_specs.py	`55.28% <66.66%> (ø)`	⬆️
superset/views/core.py	`75.24% <75%> (+0.01%)`	⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e942c9...69d4e23. Read the comment docs.

mistercrunch · 2018-12-21T04:38:34Z

@betodealmeida @hughhhh

betodealmeida

LGTM, just a few comments.

betodealmeida · 2018-12-21T20:08:52Z

superset/migrations/versions/de021a1ca60d_.py

+
+# revision identifiers, used by Alembic.
+revision = 'de021a1ca60d'
+down_revision = ('0b1f1ab473c0', 'cefabc8f7d38')


Alembic can't merge 3 heads into 1?

Oh I'm sure it does, I just rebased 2 times, let me collapse these

betodealmeida · 2018-12-21T20:12:21Z

superset/sql_lab.py

+    )
+    # Sharing a single connection and cursor across the
+    # execution of all statements (if many)
+    with closing(engine.raw_connection()) as conn:


I wish all DB modules had a context manager for connections and cursors...

betodealmeida · 2018-12-21T20:13:56Z

superset/sql_lab.py

-            cache_timeout = config.get('CACHE_DEFAULT_TIMEOUT', 0)
-        results_backend.set(key, zlib_compress(json_payload), cache_timeout)
+        key = str(uuid.uuid4())
+        logging.info(f'Storing results in results backend, key: {key}')


Yeah, f strings!

betodealmeida · 2018-12-21T20:15:49Z

superset/views/core.py

@@ -2390,11 +2391,11 @@ def results(self, key):
        if not results_backend:
            return json_error_response("Results backend isn't configured")

-        read_from_results_backend_start = utils.now_as_float()
+        read_from_results_backend_start = now_as_float()


Why not use the context manager here?

* Allow running multiple statements from SQL Lab * fix tests * More tests * merge heads * fix heads (cherry picked from commit d427db0) (cherry picked from commit 2980687a2a3382e172bf50c332abe0d2c7048b72)

* Allow running multiple statements from SQL Lab * fix tests * More tests * merge heads * fix heads (cherry picked from commit d427db0)

* Allow running multiple statements from SQL Lab * fix tests * More tests * merge heads * fix heads (cherry picked from commit d427db0) (cherry picked from commit 2980687a2a3382e172bf50c332abe0d2c7048b72)

* Allow running multiple statements from SQL Lab * fix tests * More tests * merge heads * fix heads (cherry picked from commit d427db0) (cherry picked from commit ec5ca58)

aboganas · 2019-02-13T17:45:34Z

I started facing problems with the update statement with this pr
explained here #6706

mistercrunch force-pushed the multistatement branch from 3fa790a to d9bd2d4 Compare November 5, 2018 16:52

kristw added the enhancement:request Enhancement request submitted by anyone from the community label Dec 3, 2018

mistercrunch force-pushed the multistatement branch from d9bd2d4 to 4d4c7f3 Compare December 8, 2018 18:19

mistercrunch changed the title ~~[WiP] allow running multiple statements from SQL Lab~~ [SQL Lab] Allow running multiple statements from SQL Lab Dec 9, 2018

mistercrunch changed the title ~~[SQL Lab] Allow running multiple statements from SQL Lab~~ [SQL Lab] Allow running multiple statements Dec 9, 2018

mistercrunch requested a review from betodealmeida December 9, 2018 08:51

mistercrunch force-pushed the multistatement branch 3 times, most recently from e350aac to f1e87fc Compare December 12, 2018 05:56

mistercrunch force-pushed the multistatement branch 2 times, most recently from 0ef65b4 to 0ba6da0 Compare December 19, 2018 06:46

mistercrunch force-pushed the multistatement branch from 94f0c6b to 16de920 Compare December 19, 2018 08:03

mistercrunch requested a review from john-bodley December 19, 2018 15:23

mistercrunch closed this Dec 21, 2018

mistercrunch deleted the multistatement branch December 21, 2018 05:34

mistercrunch restored the multistatement branch December 21, 2018 05:36

mistercrunch reopened this Dec 21, 2018

mistercrunch force-pushed the multistatement branch from 16de920 to 074043f Compare December 21, 2018 06:14

betodealmeida reviewed Dec 21, 2018

View reviewed changes

mistercrunch added 3 commits December 21, 2018 12:51

Allow running multiple statements from SQL Lab

4af8521

fix tests

007b1d9

More tests

db2dd15

betodealmeida mentioned this pull request Jan 15, 2019

Add extra column to SavedQuery #6687

Merged

betodealmeida mentioned this pull request Jan 15, 2019

Allow empty results in Hive (from SET, eg) #6695

Merged

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SQL Lab] Allow running multiple statements #6112

[SQL Lab] Allow running multiple statements #6112

mistercrunch commented Oct 15, 2018

ghost commented Dec 9, 2018

mistercrunch commented Dec 9, 2018

codecov-io commented Dec 19, 2018 •

edited

Loading

mistercrunch commented Dec 21, 2018

betodealmeida left a comment

betodealmeida Dec 21, 2018

mistercrunch Dec 21, 2018

betodealmeida Dec 21, 2018

betodealmeida Dec 21, 2018

betodealmeida Dec 21, 2018

aboganas commented Feb 13, 2019

[SQL Lab] Allow running multiple statements #6112

[SQL Lab] Allow running multiple statements #6112

Conversation

mistercrunch commented Oct 15, 2018

ghost commented Dec 9, 2018

mistercrunch commented Dec 9, 2018

codecov-io commented Dec 19, 2018 • edited Loading

Codecov Report

mistercrunch commented Dec 21, 2018

betodealmeida left a comment

Choose a reason for hiding this comment

betodealmeida Dec 21, 2018

Choose a reason for hiding this comment

mistercrunch Dec 21, 2018

Choose a reason for hiding this comment

betodealmeida Dec 21, 2018

Choose a reason for hiding this comment

betodealmeida Dec 21, 2018

Choose a reason for hiding this comment

betodealmeida Dec 21, 2018

Choose a reason for hiding this comment

aboganas commented Feb 13, 2019

codecov-io commented Dec 19, 2018 •

edited

Loading