Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken null handling logic #5619

Closed
wants to merge 6 commits into from
Closed

Fix broken null handling logic #5619

wants to merge 6 commits into from

Conversation

villebro
Copy link
Member

@villebro villebro commented Aug 13, 2018

This PR started out as a two-liner in one file, but grew slightly due to unrelated issues in branch. Summary of all changes:

@mistercrunch
Copy link
Member

Thanks for fixing this. LGTM apart from the build errors.

@codecov-io
Copy link

Codecov Report

Merging #5619 into 0.27 will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             0.27    #5619      +/-   ##
==========================================
- Coverage   61.39%   61.28%   -0.11%     
==========================================
  Files         369      369              
  Lines       23536    23530       -6     
  Branches     2724     2720       -4     
==========================================
- Hits        14449    14421      -28     
- Misses       9075     9097      +22     
  Partials       12       12
Impacted Files Coverage Δ
...t/assets/src/dashboard/reducers/getInitialState.js 0% <ø> (ø) ⬆️
...rset/assets/src/dashboard/actions/sliceEntities.js 32.25% <ø> (+1.95%) ⬆️
...c/dashboard/components/dnd/AddSliceDragPreview.jsx 61.9% <ø> (+2.81%) ⬆️
superset/utils.py 87.92% <ø> (-0.03%) ⬇️
superset/models/helpers.py 87.7% <100%> (-0.07%) ⬇️
superset/viz.py 79.98% <100%> (-1.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef096da...a125ca1. Read the comment docs.

@villebro
Copy link
Member Author

Ready for review @mistercrunch, please see updated summary above.

@villebro
Copy link
Member Author

ping @mistercrunch WRT the release today of 0.27.0, this PR was pending review for rc1.

@villebro villebro closed this Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants