Move flake8-related packages deps to reqs-dev.txt #5460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5460 +/- ##
=======================================
Coverage 59.11% 59.11%
=======================================
Files 372 372
Lines 23751 23751
Branches 2758 2758
=======================================
Hits 14041 14041
Misses 9695 9695
Partials 15 15Continue to review full report at Codecov.
|
john-bodley
reviewed
Jul 22, 2018
requirements-dev.txt
Outdated
| redis==2.10.6 | ||
| statsd==3.2.2 | ||
| tox==3.1.2 | ||
| console_log==0.2.10 | ||
| pylint==1.9.2 | ||
| flake8==3.5.0 |
There was a problem hiding this comment.
Nit. Can we try to keep these packages in alphabetical order.
john-bodley
approved these changes
Jul 22, 2018
john-bodley
approved these changes
Jul 23, 2018
My VIM which is integrated with flake8 wouldn't match the output from travis and would often miss things related to the flake8 plugins installed using Tox. By moving this to requirements-dev.txt, we can expect developers would have the proper configuration locally and get matching results with Travis when running flake8 or in their IDEs if its integrated with flake8..
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
* Move flake8-related packages deps to reqs-dev.txt My VIM which is integrated with flake8 wouldn't match the output from travis and would often miss things related to the flake8 plugins installed using Tox. By moving this to requirements-dev.txt, we can expect developers would have the proper configuration locally and get matching results with Travis when running flake8 or in their IDEs if its integrated with flake8.. * merging migratinos * sorting packages * Specify folder for flake8 processing * pin pycodestyle==2.3.1 * merge db migrations
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jul 26, 2018
* Move flake8-related packages deps to reqs-dev.txt My VIM which is integrated with flake8 wouldn't match the output from travis and would often miss things related to the flake8 plugins installed using Tox. By moving this to requirements-dev.txt, we can expect developers would have the proper configuration locally and get matching results with Travis when running flake8 or in their IDEs if its integrated with flake8.. * merging migratinos * sorting packages * Specify folder for flake8 processing * pin pycodestyle==2.3.1 * merge db migrations (cherry picked from commit fee5023)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Move flake8-related packages deps to reqs-dev.txt My VIM which is integrated with flake8 wouldn't match the output from travis and would often miss things related to the flake8 plugins installed using Tox. By moving this to requirements-dev.txt, we can expect developers would have the proper configuration locally and get matching results with Travis when running flake8 or in their IDEs if its integrated with flake8.. * merging migratinos * sorting packages * Specify folder for flake8 processing * pin pycodestyle==2.3.1 * merge db migrations
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My
vimwhich is integrated with flake8 wouldn't match the output fromtravis and would often miss things related to the flake8 plugins
installed using Tox.
By moving this to requirements-dev.txt, we can expect developers would
have the proper configuration locally and get matching results with
Travis when running flake8 or in their IDEs if its integrated with
flake8.