Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple of setup.py fixes #5338

Merged
merged 2 commits into from
Jul 4, 2018
Merged

A couple of setup.py fixes #5338

merged 2 commits into from
Jul 4, 2018

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Jul 3, 2018

No description provided.

@xrmx
Copy link
Contributor Author

xrmx commented Jul 3, 2018 •
edited
Loading

It may be helpful to add a python setup.py to each tox environment to catch issues like these.

@codecov-io
Copy link

codecov-io commented Jul 3, 2018 •
edited
Loading

Codecov Report

Merging #5338 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5338   +/-   ##
=======================================
  Coverage   61.33%   61.33%           
=======================================
  Files         369      369           
  Lines       23484    23484           
  Branches     2713     2713           
=======================================
  Hits        14405    14405           
  Misses       9067     9067           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d815c...7ab9d74. Read the comment docs.

@xrmx xrmx mentioned this pull request Jul 4, 2018
Closed
1 task
@mistercrunch mistercrunch merged commit 81bd5cc into apache:master Jul 4, 2018
mistercrunch pushed a commit that referenced this pull request Jul 4, 2018
@xrmx @mistercrunch
A couple of setup.py fixes (#5338)
dddcb14 
* setup: fix long description read in python2

* setup: fix git_get_sha in python3

Fix #5317

(cherry picked from commit 81bd5cc)
@mistercrunch
Copy link
Member

Added to 0.26 branch, releasing 0.26.1 with this 🍒 on top

timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
@xrmx @timifasubaa
A couple of setup.py fixes (apache#5338)
004f6d9 
* setup: fix long description read in python2

* setup: fix git_get_sha in python3

Fix apache#5317
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@xrmx @mistercrunch
A couple of setup.py fixes (apache#5338)
4f9a977 
* setup: fix long description read in python2

* setup: fix git_get_sha in python3

Fix apache#5317
@mistercrunch mistercrunch added 🍒 0.26.1 🍒 0.26.2 🍒 0.26.3 🍒 0.27.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juergenhemelt juergenhemelt juergenhemelt approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 0.26.1 🍒 0.26.2 🍒 0.26.3 🍒 0.27.0 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xrmx @codecov-io @mistercrunch @juergenhemelt