Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.26.0 upgrade fails - looks to be a change in the setup.py throwing this error #5339

Closed
1 task
darylerwin opened this issue Jul 4, 2018 · 4 comments
Closed
1 task

Comments

@darylerwin
Copy link

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • [ x] I have reproduced the issue with at least the latest released version of superset
  • [ x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.26.0 upgrade

Expected results

perform the update

Actual results

. ./venv25rc3/bin/activate
python -V
Python 2.7.12
pip -V
pip 10.0.1 from /home/derwin/venv25rc3/local/lib/python2.7/site-packages/pip (python 2.7

pip install superset --upgrade
Collecting superset
Using cached https://files.pythonhosted.org/packages/89/36/3dcf6e8e9ab80e94af0bc4e6ddf296d8ece737f52b39f721e0296267a9e8/superset-0.26.0.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-install-liolni/superset/setup.py", line 19, in
with open('README.md', encoding='utf-8') as f:
TypeError: 'encoding' is an invalid keyword argument for this function

Steps to reproduce

pip install superset --upgrade

I see that setup.py was just updated to include this encoding code - did that change the requirements to install/update setup from 2.7 to 3.x?

Also tried running
wget https://raw.githubusercontent.com/apache/incubator-superset/master/requirements.txt
pip install -r requirements.txt

@xrmx
Copy link
Contributor

xrmx commented Jul 4, 2018

Fixed in #5338

aleksi75 referenced this issue Jul 4, 2018
Seeing UnicodeDecodeError on our build system running py3.6, though I
couldn't reproduce on my local 3.6. This fix addresses the issue.

(cherry picked from commit 885d779)
@xrmx
Copy link
Contributor

xrmx commented Jul 5, 2018

This has been fixed in 0.26.1, please close.

@aleksi75
Copy link
Contributor

aleksi75 commented Jul 5, 2018

It seems that the newest distribution 0.26.1 ist not available at PyPI.

pip list --outdated --trusted-host pypi.python.org
==>
superset 0.25.6 0.26.0 sdist

@aleksi75
Copy link
Contributor

aleksi75 commented Jul 5, 2018

0.26.2 is working. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants