Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[homepage] Fix Favorites chart list #4802

Merged
merged 1 commit into from
Apr 11, 2018
Merged

[homepage] Fix Favorites chart list #4802

merged 1 commit into from
Apr 11, 2018

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Apr 10, 2018 •
edited
Loading

@codecov-io
Copy link

Codecov Report

Merging #4802 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4802   +/-   ##
=======================================
  Coverage   72.33%   72.33%           
=======================================
  Files         208      208           
  Lines       15519    15519           
  Branches     1202     1202           
=======================================
  Hits        11225    11225           
  Misses       4291     4291           
  Partials        3        3
Impacted Files Coverage Δ
...ssets/javascripts/profile/components/Favorites.jsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1627fd0...19976cd. Read the comment docs.

@michellethomas
Copy link
Contributor

michellethomas commented Apr 10, 2018 •
edited
Loading

fixes #4796

@graceguo-supercat graceguo-supercat merged commit 02a9e37 into apache:master Apr 11, 2018
@graceguo-supercat graceguo-supercat deleted the gg-FixFavoriteChartList branch April 13, 2018 03:51
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@michellethomas
[homepage] Fix Favorites chart list (apache#4802)
73e6cb9
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
@timifasubaa
[homepage] Fix Favorites chart list (apache#4802)
34ffb36
@rzlmma
Copy link

rzlmma commented Jun 15, 2018

thank you for find and fix this problem

wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
[homepage] Fix Favorites chart list (apache#4802)
06cbcf7
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michellethomas michellethomas michellethomas approved these changes

@mistercrunch mistercrunch Awaiting requested review from mistercrunch

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@graceguo-supercat @codecov-io @michellethomas @rzlmma @mistercrunch