fix(ar-modal): updateNotificationSettings not updating state

[fisjac]

SUMMARY

When changing the recipients list for an existing notification method, the state is not being changed properly. This change addresses this by reinstating missing code that was lost in a previous PR.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: Unable to save report due to Add button not enable #28149 (comment)
• Required feature flags: ALERT_REPORTS
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[sfirke]

I can't speak to the code itself sorry but the bug is real and it's addressing the right part of the codebase. Thanks @fisjac !

[alexkyurtev]

Hello , when do you expect the PR to be merged ?

[dpgaspar]

can you add a unit test for updateNotificationSetting

[mistercrunch]

Rush-merging since this needs to make an imminent cut.

[alexkyurtev]

Hello , I suppose that the changes are live now ? Or ?

[sfirke]

These changes would be live on master branch (you could run the nightly, unstable build image apache/superset:latest to verify) but did not make it into 4.0.1. They will be present in 4.0.2 and 4.1.0.

[Nick-ATOR]

Is there any way to directly implement this fix in a K8s deployment?

[sfirke]

If a community member wanted to take the 4.0.1 release, cherry-pick this PR onto it, and package it up for the world, that might be widely useful. I hope 4.0.2 and 4.1.0 come out soon but in the meantime someone could run with that.