lint

apache · May 9, 2024 · 10fb0a3 · 10fb0a3
1 parent fa2083d
commit 10fb0a3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/superset-frontend/src/features/alerts/AlertReportModal.tsx b/superset-frontend/src/features/alerts/AlertReportModal.tsx
@@ -553,6 +553,9 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
     index: number,
     setting: NotificationSetting,
   ) => {
+    const settings: NotificationSetting[] = [...notificationSettings];
+    settings[index] = setting;
+
     // if you've changed notification method -> reset recipients
     if (notificationSettings[index].method !== setting.method) {
       notificationSettings[index] = setting;
@@ -569,10 +572,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
         setNotificationAddState('active');
       }
     } else {
-      // if notification method has not changed -> update
-      const settings: NotificationSetting[] = [...notificationSettings];
-      settings[index] = setting;
-      setNotificationSettings(settings)
+      setNotificationSettings(settings);
     }
   };