Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): run unit tests on script changes #27297

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

eschutho
Copy link
Member

SUMMARY

Since we have some unit tests for files in the script folder, we should enable the unit tests to run on those changes. See #27296

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho marked this pull request as ready for review February 29, 2024 01:54
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.33%. Comparing base (0468c57) to head (0a85939).
Report is 1482 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27297   +/-   ##
=======================================
  Coverage   67.33%   67.33%           
=======================================
  Files        1908     1908           
  Lines       74540    74540           
  Branches     8312     8312           
=======================================
+ Hits        50192    50193    +1     
+ Misses      22295    22294    -1     
  Partials     2053     2053           
Flag Coverage Δ
mysql 77.97% <ø> (-0.03%) ⬇️
postgres 78.10% <ø> (ø)
python 78.24% <ø> (+<0.01%) ⬆️
sqlite 77.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@geido geido merged commit 228d27f into apache:master Feb 29, 2024
26 of 39 checks passed
@geido geido deleted the elizabeth/run-unit-on-scripts branch February 29, 2024 10:47
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels github_actions Pull requests that update GitHub Actions code size/XS 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants