Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "chore: Replace deprecated command with environment file (#240… #27296

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix: Revert "chore: Replace deprecated command with environment file (#240… #27296

merged 1 commit into from
Feb 29, 2024

Conversation

eschutho
Copy link
Member

…63)"

This reverts commit e817b48.
This PR is failing some test that unfortunately were not triggered to run on script changes. I'll follow up with a PR that will enable the unit tests on updates to any files in the script directory, and then we can try to reopen this PR and fix the tests.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho marked this pull request as ready for review February 29, 2024 01:49
@eschutho eschutho mentioned this pull request Feb 29, 2024
Merged
9 tasks
@eschutho eschutho changed the title Revert "chore: Replace deprecated command with environment file (#240… revert: "chore: Replace deprecated command with environment file (#240… Feb 29, 2024
@eschutho eschutho changed the title revert: "chore: Replace deprecated command with environment file (#240… fix: Revert "chore: Replace deprecated command with environment file (#240… Feb 29, 2024
@geido geido merged commit d6e8dd1 into apache:master Feb 29, 2024
22 of 37 checks passed
@geido geido deleted the elizabeth/revert-24063 branch February 29, 2024 09:37
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@eschutho @sfirke
fix: Revert "chore: Replace deprecated command with environment file (a…
0444f28 
…pache#240… (apache#27296)
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@eschutho @qleroy
fix: Revert "chore: Replace deprecated command with environment file (a…
ba0f97c 
…pache#240… (apache#27296)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@eschutho
fix: Revert "chore: Replace deprecated command with environment file (a…
e840d3d 
…pache#240… (apache#27296)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eschutho @geido @mistercrunch