-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): improve docker tags to be cleared and avoid conflicts #26787
Conversation
We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the |
fdf515c
to
1107fe2
Compare
fef0e81
to
a95ee1c
Compare
@mistercrunch for the ASF release, the docker image creation is still handled through the CI when the sha is marked for release, so there's currently no separate or manual process that's done. |
a95ee1c
to
bb87bf6
Compare
a050204
to
11bc75b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26787 +/- ##
=======================================
Coverage 67.29% 67.29%
=======================================
Files 1895 1895
Lines 74249 74249
Branches 8257 8257
=======================================
Hits 49968 49968
Misses 22206 22206
Partials 2075 2075
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1c6199f
to
7b20d29
Compare
Note that when we talk about the I'm only bringing that up here to ask that we retain functionality such that when a version is released tagged like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b573177
to
bb4e221
Compare
244ed02
to
b7ba796
Compare
Improving the docker tag naming scheme to:
-arm
for platofrm =linux-arm64
, and leave the amd builds without suffix since they're used already, before this fix we would have conflicts between tags / images. More on this here Issue with the apache/superset:dockerize #26788dev
tag (ieapache/supserset:dev
, andapache/supserset:dev-arm
) to top of themaster
branch. This tag only gets generated then.apache/supserset:lean
andapache/supserset:py310
, ...A question remains
Where should we point top level builds like
apache/supserset:lean
andapache/supserset:lean-arm
or even the top-most levelapache/supserset
? Seems it should be pointed to the latest official ASF release version/build, unclear if it should be done in CI, or a simpledocker tag
command as part of the ASF release process, pointing to the image of the right SHA (that tag should be computed and exist, so all we need is to point to the right place)