Skip to content

Commit a95ee1c

Browse files
committed
pointing dev tag to the top of master
1 parent b621e7c commit a95ee1c

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

scripts/docker_build_push.sh

+4-9
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ if [[ "${BUILD_PLATFORM}" == "linux/arm64" ]]; then
7878
PLATFORM_SUFFIX="-arm"
7979
fi
8080

81-
MAIN_UNIQUE_TAG="${REPO_NAME}:${SHA}-${TARGET}-${SAFE_BUILD_PLATFORM}-${BUILD_ARG}"
81+
VERBOSE_TAG="${REPO_NAME}:${SHA}-${TARGET}-${SAFE_BUILD_PLATFORM}-${BUILD_ARG}"
8282

8383
case "${TARGET}" in
8484
"dev")
@@ -115,21 +115,16 @@ if [[ -n "$TAG" ]]; then
115115
TAG_SUFFIX="-$TAG"
116116
fi
117117

118-
DOCKER_TAGS="-t ${MAIN_UNIQUE_TAG}"
118+
DOCKER_TAGS="-t ${VERBOSE_TAG}"
119119
DOCKER_TAGS="${DOCKER_TAGS} -t ${REPO_NAME}:${SHA}${TAG_SUFFIX}${PLATFORM_SUFFIX}"
120120
DOCKER_TAGS="${DOCKER_TAGS} -t ${REPO_NAME}:${REFSPEC}${TAG_SUFFIX}${PLATFORM_SUFFIX}"
121121
DOCKER_TAGS="${DOCKER_TAGS} -t ${REPO_NAME}:${LATEST_TAG}${TAG_SUFFIX}${PLATFORM_SUFFIX}"
122122

123-
if [[ "${GITHUB_EVENT_NAME}" == "push" ]]; then
124-
# only adding top level tags on master
123+
if [[ "${GITHUB_EVENT_NAME}" == "push" && "${GITHUB_REF}" == "refs/heads/master" && "${TAG}" == "dev" ]]; then
124+
# the `apache-superset:dev` docker tag points to top of master
125125
DOCKER_TAGS="${DOCKER_TAGS} -t ${REPO_NAME}:${TAG}${PLATFORM_SUFFIX}"
126126
fi
127127

128-
if [[ "${TAG}" == "lean" ]]; then
129-
# add main tag based on lean
130-
DOCKER_TAGS="${DOCKER_TAGS} -t ${REPO_NAME}"
131-
fi
132-
133128
if [ -z "${DOCKERHUB_TOKEN}" ]; then
134129
# Skip if secrets aren't populated -- they're only visible for actions running in the repo (not on forks)
135130
echo "Skipping Docker push"

0 commit comments

Comments
 (0)