Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translations): some fix or add for Scheduler translation #25873

Closed
wants to merge 2 commits into from

Conversation

xavier-GitHub76
Copy link
Contributor

Fix typo for "Plannifeir", "Plannifier"
Add translations for "Schedule a new email report", "Scheduled task executor not found"

@john-bodley
Copy link
Member

john-bodley commented Nov 6, 2023

Thanks @xavier-GitHub76 for the PR. Would you mind running tox -e pre-commit locally which should remedy the prettier issue?

@xavier-GitHub76
Copy link
Contributor Author

Thanks for your actions.
@john-bodley, I'm OK to do but I don't know how to do.
Best regards

@john-bodley
Copy link
Member

@xavier-GitHub76 see these instructions on how you should configure your local environment to run the Git hooks (which include prettier).

@xavier-GitHub76
Copy link
Contributor Author

Thanks for precisions.

I do :
pip3 install -r requirements/integration.txt
image

pre-commit install
image

tox -e pre-commit
image
image
image

3 errors are founed :
image

@rusackas
Copy link
Member

I think the suggested edits will fix the linting issues, but I believe the edits should be made to the .po files, and the .json files will be generated from those.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The json files are no longer part of the repo itself. Please make changes to the .po files, and the other (.json and .mo) files will be generated when needed.

@@ -249,8 +249,8 @@
"Additional information": ["Informations additionnelles"],
"Additional parameters": ["Paramètres supplémentaires"],
"Additional text to add before or after the value, e.g. unit": [""],
"Adjust how this database will interact with SQL Lab.": [""],
"Adjust performance settings of this database.": [""],
"Adjust how this database will interact with SQL Lab.": ["Ajustez la façon dont cette base de données interagira avec SQL Lab."],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Adjust how this database will interact with SQL Lab.": ["Ajustez la façon dont cette base de données interagira avec SQL Lab."],
"Adjust how this database will interact with SQL Lab.": [
"Ajustez la façon dont cette base de données interagira avec SQL Lab."
],

"Adjust how this database will interact with SQL Lab.": [""],
"Adjust performance settings of this database.": [""],
"Adjust how this database will interact with SQL Lab.": ["Ajustez la façon dont cette base de données interagira avec SQL Lab."],
"Adjust performance settings of this database.": ["Ajustez les paramètres de performances de cette base de données."],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Adjust performance settings of this database.": ["Ajustez les paramètres de performances de cette base de données."],
"Adjust performance settings of this database.": [
"Ajustez les paramètres de performances de cette base de données."
],

@@ -1887,7 +1887,7 @@
""
],
"Include Series": [""],
"Include a description that will be sent with your report": [""],
"Include a description that will be sent with your report": ["Incluez une description qui sera envoyée avec votre rapport"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Include a description that will be sent with your report": ["Incluez une description qui sera envoyée avec votre rapport"],
"Include a description that will be sent with your report": [
"Incluez une description qui sera envoyée avec votre rapport"
],

@@ -2851,15 +2851,15 @@
"Scatter Plot has the horizontal axis in linear units, and the points are connected in order. It shows a statistical relationship between two variables.": [
""
],
"Schedule": ["Plannifeir"],
"Schedule": ["Planification"],
"Schedule a new email report": ["Planifier un nouveau rapport par e-mail"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Schedule a new email report": ["Planifier un nouveau rapport par e-mail"],
"Schedule a new email report": [
"Planifier un nouveau rapport par e-mail"
],

"Schedule the query periodically": [
"Planifier la requête de façon périodique"
],
"Schedule the query periodically": ["Planifier la requête de façon périodique"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Schedule the query periodically": ["Planifier la requête de façon périodique"],
"Schedule the query periodically": [
"Planifier la requête de façon périodique"
],

"Scheduled": ["Programmé"],
"Scheduled at (UTC)": ["Plannifié à (UTC)"],
"Scheduled at (UTC)": ["Planifié à (UTC)"],
"Scheduled task executor not found": ["Exécuteur de tâches planifiées introuvable"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Scheduled task executor not found": ["Exécuteur de tâches planifiées introuvable"],
"Scheduled task executor not found": [
"Exécuteur de tâches planifiées introuvable"
],

@mistercrunch mistercrunch deleted the branch apache:3.0 November 25, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants