[SPARK-33084][CORE][SQL] Add jar support ivy path #29966

AngersZhuuuu · 2020-10-07T11:38:50Z

What changes were proposed in this pull request?

Support add jar with ivy path

Why are the changes needed?

Since submit app can support ivy, add jar we can also support ivy now.

Does this PR introduce any user-facing change?

User can add jar with sql like

add jar ivy:://group:artifict:version?exclude=xxx,xxx&transitive=true
add jar ivy:://group:artifict:version?exclude=xxx,xxx&transitive=false

core api

sparkContext.addJar("ivy:://group:artifict:version?exclude=xxx,xxx&transitive=true")
sparkContext.addJar("ivy:://group:artifict:version?exclude=xxx,xxx&transitive=false")

Doc Update snapshot

How was this patch tested?

Added UT

SparkQA · 2020-10-07T12:41:00Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34113/

SparkQA · 2020-10-07T13:03:05Z

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34113/

SparkQA · 2020-10-07T14:07:17Z

Test build #129507 has finished for PR 29966 at commit 51daf9a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

…/spark into support-add-jar-ivy

SparkQA · 2020-10-07T16:44:24Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34124/

SparkQA · 2020-10-07T17:08:26Z

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34124/

SparkQA · 2020-10-07T18:50:51Z

Test build #129520 has finished for PR 29966 at commit d6e8caf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-10-08T09:06:47Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34157/

SparkQA · 2020-10-08T09:24:56Z

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34157/

SparkQA · 2020-10-08T11:19:28Z

Test build #129551 has finished for PR 29966 at commit 169e1f8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AngersZhuuuu · 2020-10-09T03:10:04Z

cc @dongjoon-hyun As I have mentioned in https://issues.apache.org/jira/browse/SPARK-29288, make this pr support ivy path like https://issues.apache.org/jira/browse/HIVE-9664

dongjoon-hyun · 2020-10-09T16:14:28Z

Got it. Thank you, @AngersZhuuuu

SparkQA · 2020-11-23T01:27:53Z

Test build #131522 has finished for PR 29966 at commit b3e3211.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-11-23T02:07:47Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36125/

SparkQA · 2020-11-23T02:23:23Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36127/

SparkQA · 2020-11-23T02:37:59Z

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36125/

SparkQA · 2020-11-23T02:48:28Z

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36127/

SparkQA · 2020-11-23T04:21:03Z

Test build #131524 has finished for PR 29966 at commit 9161340.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-12-24T03:29:13Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37926/

SparkQA · 2020-12-24T03:33:54Z

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37926/

SparkQA · 2020-12-24T05:26:23Z

Test build #133335 has finished for PR 29966 at commit 4c44dae.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

dongjoon-hyun

+1, LGTM for Apache Spark 3.2.0. Thank you, @AngersZhuuuu and all.

Feel free to merge, @maropu .

dongjoon-hyun · 2020-12-24T22:25:06Z

BTW, Merry Christmas and Happy New Year, all!

maropu · 2020-12-25T00:08:54Z

Thanks, @AngersZhuuuu @dongjoon-hyun ! Merged to master. Happy Merry Christmas, too!

maropu · 2020-12-25T00:24:34Z

FYI: @gatorsmile @cloud-fan

AngersZhuuuu · 2020-12-25T01:47:36Z

Merry Christmas! Thanks all for your patient reviews.

…() 's return parameter ### What changes were proposed in this pull request? Per discuss in #29966 (comment) We'd better change `SparkSubmitUtils.resolveMavenCoordinates()` 's return value as `Seq[String]` ### Why are the changes needed? refactor code ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existed UT Closes #30922 from AngersZhuuuu/SPARK-33908. Authored-by: angerszhu <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>

koertkuipers · 2020-12-31T03:25:55Z

please note this breaks scala 2.13
where can i find source code for SPARK-33084.jar?

[info]   Cause: java.lang.NoSuchMethodError: org.apache.spark.sql.types.StructType$.apply(Lscala/collection/Seq;)Lorg/apache/spark/sql/types/StructType;
[info]   at org.apache.spark.examples.sql.Spark33084.inputSchema(Spark33084.scala:9)
[info]   at org.apache.spark.sql.execution.aggregate.ScalaUDAF.<init>(udaf.scala:347)

AngersZhuuuu · 2020-12-31T03:27:29Z

please note this breaks scala 2.13
where can i find source code for SPARK-33084.jar?

[info]   Cause: java.lang.NoSuchMethodError: org.apache.spark.sql.types.StructType$.apply(Lscala/collection/Seq;)Lorg/apache/spark/sql/types/StructType;
[info]   at org.apache.spark.examples.sql.Spark33084.inputSchema(Spark33084.scala:9)
[info]   at org.apache.spark.sql.execution.aggregate.ScalaUDAF.<init>(udaf.scala:347)

Defined it by my self. I will fix this issue. Can you show how to reproduce this error, source code is
#29966 (comment)

AngersZhuuuu · 2020-12-31T03:50:23Z

please note this breaks scala 2.13
where can i find source code for SPARK-33084.jar?

[info]   Cause: java.lang.NoSuchMethodError: org.apache.spark.sql.types.StructType$.apply(Lscala/collection/Seq;)Lorg/apache/spark/sql/types/StructType;
[info]   at org.apache.spark.examples.sql.Spark33084.inputSchema(Spark33084.scala:9)
[info]   at org.apache.spark.sql.execution.aggregate.ScalaUDAF.<init>(udaf.scala:347)

Can you show how you reproduce this error?

koertkuipers · 2020-12-31T05:49:52Z

$ dev/change-scala-version.sh 2.13
$ SBT_MAVEN_PROFILES="-Pscala-2.13" sbt
sbt:spark-parent> project sql
sbt:spark-sql> testOnly org.apache.spark.sql.SQLQuerySuite

### What changes were proposed in this pull request? Fix UT according to #29966 (comment) Change StructType construct from ``` def inputSchema: StructType = StructType(StructField("inputColumn", LongType) :: Nil) ``` to ``` def inputSchema: StructType = new StructType().add("inputColumn", LongType) ``` The whole udf class is : ``` package org.apache.spark.examples.sql import org.apache.spark.sql.expressions.{MutableAggregationBuffer, UserDefinedAggregateFunction} import org.apache.spark.sql.types._ import org.apache.spark.sql.Row class Spark33084 extends UserDefinedAggregateFunction { // Data types of input arguments of this aggregate function def inputSchema: StructType = new StructType().add("inputColumn", LongType) // Data types of values in the aggregation buffer def bufferSchema: StructType = new StructType().add("sum", LongType).add("count", LongType) // The data type of the returned value def dataType: DataType = DoubleType // Whether this function always returns the same output on the identical input def deterministic: Boolean = true // Initializes the given aggregation buffer. The buffer itself is a `Row` that in addition to // standard methods like retrieving a value at an index (e.g., get(), getBoolean()), provides // the opportunity to update its values. Note that arrays and maps inside the buffer are still // immutable. def initialize(buffer: MutableAggregationBuffer): Unit = { buffer(0) = 0L buffer(1) = 0L } // Updates the given aggregation buffer `buffer` with new input data from `input` def update(buffer: MutableAggregationBuffer, input: Row): Unit = { if (!input.isNullAt(0)) { buffer(0) = buffer.getLong(0) + input.getLong(0) buffer(1) = buffer.getLong(1) + 1 } } // Merges two aggregation buffers and stores the updated buffer values back to `buffer1` def merge(buffer1: MutableAggregationBuffer, buffer2: Row): Unit = { buffer1(0) = buffer1.getLong(0) + buffer2.getLong(0) buffer1(1) = buffer1.getLong(1) + buffer2.getLong(1) } // Calculates the final result def evaluate(buffer: Row): Double = buffer.getLong(0).toDouble / buffer.getLong(1) } ``` ### Why are the changes needed? Fix UT for scala 2.13 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existed UT Closes #30980 from AngersZhuuuu/spark-33084-followup. Authored-by: angerszhu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

wangyum · 2021-01-10T05:32:36Z

core/src/test/scala/org/apache/spark/util/DependencyUtils.scala

+
+import org.apache.spark.SparkFunSuite
+
+class DependencyUtilsSuite extends SparkFunSuite {


Rename file name to DependencyUtilsSuite.scala?

wangyum · 2021-01-10T05:34:28Z

core/src/test/scala/org/apache/spark/util/DependencyUtils.scala

+
+    val e3 = intercept[IllegalArgumentException] {
+      DependencyUtils.resolveMavenDependencies(
+        URI.create("ivy://org.apache.hive:hive-contrib:2.3.7?foo="))


Do we need to keep 2.3.7 consistent with the built-in Hive version?

Do we need to keep 2.3.7 consistent with the built-in Hive version?

Emmm, is there any concern about this?

Do we need to keep 2.3.7 consistent with the built-in Hive version?

How about #31118

### What changes were proposed in this pull request? According to #29966 (comment) Use wrong name about suite file, this pr to fix this problem. And change to use some fake ivy link for this test ### Why are the changes needed? Follow file name rule ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No Closes #31118 from AngersZhuuuu/SPARK-33084-FOLLOW-UP. Authored-by: angerszhu <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>

### What changes were proposed in this pull request? According to apache/spark#29966 (comment) Use wrong name about suite file, this pr to fix this problem. And change to use some fake ivy link for this test ### Why are the changes needed? Follow file name rule ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No Closes #31118 from AngersZhuuuu/SPARK-33084-FOLLOW-UP. Authored-by: angerszhu <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>

… with Hive transitive behavior ### What changes were proposed in this pull request? SPARK-33084 added the ability to use ivy coordinates with `SparkContext.addJar`. PR #29966 claims to mimic Hive behavior although I found a few cases where it doesn't 1) The default value of the transitive parameter is false, both in case of parameter not being specified in coordinate or parameter value being invalid. The Hive behavior is that transitive is [true if not specified](https://github.com/apache/hive/blob/cb2ac3dcc6af276c6f64ee00f034f082fe75222b/ql/src/java/org/apache/hadoop/hive/ql/util/DependencyResolver.java#L169) in the coordinate and [false for invalid values](https://github.com/apache/hive/blob/cb2ac3dcc6af276c6f64ee00f034f082fe75222b/ql/src/java/org/apache/hadoop/hive/ql/util/DependencyResolver.java#L124). Also, regardless of Hive, I think a default of true for the transitive parameter also matches [ivy's own defaults](https://ant.apache.org/ivy/history/2.5.0/ivyfile/dependency.html#_attributes). 2) The parameter value for transitive parameter is regarded as case-sensitive [based on the understanding](#29966 (comment)) that Hive behavior is case-sensitive. However, this is not correct, Hive [treats the parameter value case-insensitively](https://github.com/apache/hive/blob/cb2ac3dcc6af276c6f64ee00f034f082fe75222b/ql/src/java/org/apache/hadoop/hive/ql/util/DependencyResolver.java#L122). I propose that we be compatible with Hive for these behaviors ### Why are the changes needed? To make `ADD JAR` with ivy coordinates compatible with Hive's transitive behavior ### Does this PR introduce _any_ user-facing change? The user-facing changes here are within master as the feature introduced in SPARK-33084 has not been released yet 1. Previously an ivy coordinate without `transitive` parameter specified did not resolve transitive dependency, now it does. 2. Previously an `transitive` parameter value was treated case-sensitively. e.g. `transitive=TRUE` would be treated as false as it did not match exactly `true`. Now it will be treated case-insensitively. ### How was this patch tested? Modified existing unit tests to test new behavior Add new unit test to cover usage of `exclude` with unspecified `transitive` Closes #31623 from shardulm94/spark-34506. Authored-by: Shardul Mahadik <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>

… SQLQuerySuite to avoid clearing ivy.home ### What changes were proposed in this pull request? Add the `ResetSystemProperties` trait to `SQLQuerySuite` so that system property changes made by any of the tests will not affect other suites/tests. Specifically, the system property changes made by `SPARK-33084: Add jar support Ivy URI in SQL -- jar contains udf class` are targeted here (which sets and then clears `ivy.home`). ### Why are the changes needed? PR #29966 added a new test case that adjusts the `ivy.home` system property to force Ivy to resolve an artifact from a custom location. At the end of the test, the value is cleared. Clearing the value meant that, if a custom value of `ivy.home` was configured externally, it would not apply for tests run after this test case. ### Does this PR introduce _any_ user-facing change? No, this is only in tests. ### How was this patch tested? Existing unit tests continue to pass, whether or not `spark.jars.ivySettings` is configured (which adjusts the behavior of Ivy w.r.t. handling of `ivy.home` and `ivy.default.ivy.user.dir` properties). Closes #31694 from xkrogen/xkrogen-SPARK-33084-ivyhome-sysprop-followon. Authored-by: Erik Krogen <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>

Support add jar with ivy path Since submit app can support ivy, add jar we can also support ivy now. User can add jar with sql like ``` add jar ivy:://group:artifict:version?exclude=xxx,xxx&transitive=true add jar ivy:://group:artifict:version?exclude=xxx,xxx&transitive=false ``` core api ``` sparkContext.addJar("ivy:://group:artifict:version?exclude=xxx,xxx&transitive=true") sparkContext.addJar("ivy:://group:artifict:version?exclude=xxx,xxx&transitive=false") ``` ![image](https://user-images.githubusercontent.com/46485123/101227738-de451200-36d3-11eb-813d-78a8b879da4f.png) Added UT Closes apache#29966 from AngersZhuuuu/support-add-jar-ivy. Lead-authored-by: angerszhu <[email protected]> Co-authored-by: AngersZhuuuu <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>

… with Hive transitive behavior ### What changes were proposed in this pull request? SPARK-33084 added the ability to use ivy coordinates with `SparkContext.addJar`. PR apache#29966 claims to mimic Hive behavior although I found a few cases where it doesn't 1) The default value of the transitive parameter is false, both in case of parameter not being specified in coordinate or parameter value being invalid. The Hive behavior is that transitive is [true if not specified](https://github.com/apache/hive/blob/cb2ac3dcc6af276c6f64ee00f034f082fe75222b/ql/src/java/org/apache/hadoop/hive/ql/util/DependencyResolver.java#L169) in the coordinate and [false for invalid values](https://github.com/apache/hive/blob/cb2ac3dcc6af276c6f64ee00f034f082fe75222b/ql/src/java/org/apache/hadoop/hive/ql/util/DependencyResolver.java#L124). Also, regardless of Hive, I think a default of true for the transitive parameter also matches [ivy's own defaults](https://ant.apache.org/ivy/history/2.5.0/ivyfile/dependency.html#_attributes). 2) The parameter value for transitive parameter is regarded as case-sensitive [based on the understanding](apache#29966 (comment)) that Hive behavior is case-sensitive. However, this is not correct, Hive [treats the parameter value case-insensitively](https://github.com/apache/hive/blob/cb2ac3dcc6af276c6f64ee00f034f082fe75222b/ql/src/java/org/apache/hadoop/hive/ql/util/DependencyResolver.java#L122). I propose that we be compatible with Hive for these behaviors ### Why are the changes needed? To make `ADD JAR` with ivy coordinates compatible with Hive's transitive behavior ### Does this PR introduce _any_ user-facing change? The user-facing changes here are within master as the feature introduced in SPARK-33084 has not been released yet 1. Previously an ivy coordinate without `transitive` parameter specified did not resolve transitive dependency, now it does. 2. Previously an `transitive` parameter value was treated case-sensitively. e.g. `transitive=TRUE` would be treated as false as it did not match exactly `true`. Now it will be treated case-insensitively. ### How was this patch tested? Modified existing unit tests to test new behavior Add new unit test to cover usage of `exclude` with unspecified `transitive` Closes apache#31623 from shardulm94/spark-34506. Authored-by: Shardul Mahadik <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>

AngersZhuuuu added 2 commits October 7, 2020 19:31

[SPARK-33084][CORE][SQL]Add jar support ivy path

afaf7bd

Merge branch 'master' into support-add-jar-ivy

51daf9a

AngersZhuuuu changed the title ~~[SPARK-33084][CORE][SQL]Add jar support ivy path~~ [WIP][SPARK-33084][CORE][SQL]Add jar support ivy path Oct 7, 2020

AngersZhuuuu added 2 commits October 8, 2020 00:00

Update SparkContextSuite.scala

3579de0

Merge branch 'support-add-jar-ivy' of https://github.com/AngersZhuuuu…

d6e8caf

…/spark into support-add-jar-ivy

Update Utils.scala

169e1f8

AngersZhuuuu changed the title ~~[WIP][SPARK-33084][CORE][SQL]Add jar support ivy path~~ [SPARK-33084][CORE][SQL]Add jar support ivy path Oct 9, 2020

dongjoon-hyun added the SQL label Oct 15, 2020

Merge branch 'master' into support-add-jar-ivy

0e589ec

AngersZhuuuu mentioned this pull request Nov 21, 2020

[SPARK-28704][SQL][TEST] Add back Skiped HiveExternalCatalogVersionsSuite in HiveSparkSubmitSuite at JDK9+ #30451

Closed

resolve conflict

b3e3211

github-actions bot added the CORE label Nov 23, 2020

Update SessionState.scala

9161340

dongjoon-hyun approved these changes Dec 24, 2020

View reviewed changes

maropu closed this in 10b6466 Dec 25, 2020

This was referenced Dec 25, 2020

[SPARK-33908][CORE] Refactor SparkSubmitUtils.resolveMavenCoordinates() 's return parameter #30922

Closed

[SPARK-33912][SQL] Refactor DependencyUtils ivy property parameter #30928

Closed

AngersZhuuuu mentioned this pull request Dec 31, 2020

[SPARK-33084][SQL][TESTS][FOLLOW-UP] Fix Scala 2.13 UT failure #30980

Closed

wangyum reviewed Jan 10, 2021

View reviewed changes

AngersZhuuuu mentioned this pull request Jan 11, 2021

[SPARK-33084][CORE][SQL] Rename Unit test file and use fake ivy link #31118

Closed

shardulm94 mentioned this pull request Feb 23, 2021

[SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior #31623

Closed

xkrogen mentioned this pull request Mar 1, 2021

[SPARK-33084][SQL][TEST][FOLLOWUP] Add ResetSystemProperties trait to SQLQuerySuite to avoid clearing ivy.home #31694

Closed

HyukjinKwon mentioned this pull request Mar 16, 2021

Using the library in Databricks environment yaooqinn/itachi#8

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SPARK-33084][CORE][SQL] Add jar support ivy path #29966

[SPARK-33084][CORE][SQL] Add jar support ivy path #29966

AngersZhuuuu commented Oct 7, 2020 •

edited

Loading

SparkQA commented Oct 7, 2020

SparkQA commented Oct 7, 2020

SparkQA commented Oct 7, 2020

SparkQA commented Oct 7, 2020

SparkQA commented Oct 7, 2020

SparkQA commented Oct 7, 2020

SparkQA commented Oct 8, 2020

SparkQA commented Oct 8, 2020

SparkQA commented Oct 8, 2020

AngersZhuuuu commented Oct 9, 2020

dongjoon-hyun commented Oct 9, 2020

SparkQA commented Nov 23, 2020

SparkQA commented Nov 23, 2020

SparkQA commented Nov 23, 2020

SparkQA commented Nov 23, 2020

SparkQA commented Nov 23, 2020

SparkQA commented Nov 23, 2020

SparkQA commented Dec 24, 2020

SparkQA commented Dec 24, 2020

SparkQA commented Dec 24, 2020

dongjoon-hyun left a comment

dongjoon-hyun commented Dec 24, 2020

maropu commented Dec 25, 2020

maropu commented Dec 25, 2020

AngersZhuuuu commented Dec 25, 2020

koertkuipers commented Dec 31, 2020

AngersZhuuuu commented Dec 31, 2020 •

edited

Loading

AngersZhuuuu commented Dec 31, 2020

koertkuipers commented Dec 31, 2020

wangyum Jan 10, 2021

wangyum Jan 10, 2021

AngersZhuuuu Jan 11, 2021

AngersZhuuuu Jan 11, 2021


		import org.apache.spark.SparkFunSuite

		class DependencyUtilsSuite extends SparkFunSuite {

[SPARK-33084][CORE][SQL] Add jar support ivy path #29966

[SPARK-33084][CORE][SQL] Add jar support ivy path #29966

Conversation

AngersZhuuuu commented Oct 7, 2020 • edited Loading

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

Doc Update snapshot

How was this patch tested?

SparkQA commented Oct 7, 2020

SparkQA commented Oct 7, 2020

SparkQA commented Oct 7, 2020

SparkQA commented Oct 7, 2020

SparkQA commented Oct 7, 2020

SparkQA commented Oct 7, 2020

SparkQA commented Oct 8, 2020

SparkQA commented Oct 8, 2020

SparkQA commented Oct 8, 2020

AngersZhuuuu commented Oct 9, 2020

dongjoon-hyun commented Oct 9, 2020

SparkQA commented Nov 23, 2020

SparkQA commented Nov 23, 2020

SparkQA commented Nov 23, 2020

SparkQA commented Nov 23, 2020

SparkQA commented Nov 23, 2020

SparkQA commented Nov 23, 2020

SparkQA commented Dec 24, 2020

SparkQA commented Dec 24, 2020

SparkQA commented Dec 24, 2020

dongjoon-hyun left a comment

Choose a reason for hiding this comment

dongjoon-hyun commented Dec 24, 2020

maropu commented Dec 25, 2020

maropu commented Dec 25, 2020

AngersZhuuuu commented Dec 25, 2020

koertkuipers commented Dec 31, 2020

AngersZhuuuu commented Dec 31, 2020 • edited Loading

AngersZhuuuu commented Dec 31, 2020

koertkuipers commented Dec 31, 2020

wangyum Jan 10, 2021

Choose a reason for hiding this comment

wangyum Jan 10, 2021

Choose a reason for hiding this comment

AngersZhuuuu Jan 11, 2021

Choose a reason for hiding this comment

AngersZhuuuu Jan 11, 2021

Choose a reason for hiding this comment

AngersZhuuuu commented Oct 7, 2020 •

edited

Loading

AngersZhuuuu commented Dec 31, 2020 •

edited

Loading