fix RequestCode overflowed issues:8868

[zzjcool]

Which Issue(s) This PR Fixes

Fixes #8868

Brief Description

Description:
The following message request codes exceed the maximum value for a short integer (32767), resulting in an overflow. The original values are as follows:

public static final int POP_MESSAGE = 200050;
public static final int ACK_MESSAGE = 200051;
public static final int BATCH_ACK_MESSAGE = 200151;
public static final int PEEK_MESSAGE = 200052;
public static final int CHANGE_MESSAGE_INVISIBLETIME = 200053;
public static final int NOTIFICATION = 200054;
public static final int POLLING_INFO = 200055;

Actual Values After Overflow:
Due to the overflow, the actual values of these constants are:

public static final int POP_MESSAGE = 3442;
public static final int ACK_MESSAGE = 3443;
public static final int BATCH_ACK_MESSAGE = 3543;
public static final int PEEK_MESSAGE = 3444;
public static final int CHANGE_MESSAGE_INVISIBLETIME = 3445;
public static final int NOTIFICATION = 3446;
public static final int POLLING_INFO = 3447;

How Did You Test This Change?

unit test

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.15%. Comparing base (ecb45bb) to head (f8d7bc6).

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #8871      +/-   ##
=============================================
- Coverage      47.19%   47.15%   -0.04%     
+ Complexity     11676    11668       -8     
=============================================
  Files           1304     1304              
  Lines          90984    90984              
  Branches       11668    11668              
=============================================
- Hits           42936    42906      -30     
- Misses         42765    42789      +24     
- Partials        5283     5289       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[universefeeler]

unsubscribe 在 2024-10-29 17:15:23，"Codecov Comments Bot" ***@***.***> 写道： Codecov Report All modified and coverable lines are covered by tests ✅ Project coverage is 47.15%. Comparing base (ecb45bb) to head (f8d7bc6). Additional details and impacted files @@ Coverage Diff @@## develop #8871 +/- ## ============================================= - Coverage 47.19% 47.15% -0.04% + Complexity 11676 11668 -8 ============================================= Files 1304 1304 Lines 90984 90984 Branches 11668 11668 ============================================= - Hits 42936 42906 -30 - Misses 42765 42789 +24 - Partials 5283 5289 +6 ☔ View full report in Codecov by Sentry. Have feedback on the report? Share it here. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[yuz10]

I think the change breaks compatibility, In fact, the request code is int when use serializeTypeCurrentRPC=json. which is default. so old clients will fail to connect new server, and new clients fail to connet old server. the fix is included in #5909

[lizhanhui]

I think the change breaks compatibility, In fact, the request code is int when use serializeTypeCurrentRPC=json. which is default. so old clients will fail to connect new server, and new clients fail to connet old server. the fix is included in #5909

Sounds reasonable, let me double check.

[lizhanhui]

There is no easy way to fix the overflow issue. We need to revert this change @zzjcool