-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #5684] request code should be short, to support serializeTypeCurrentRPC=ROCKETMQ #5909
Conversation
remoting/src/test/java/org/apache/rocketmq/remoting/protocol/RequestCodeTest.java
Outdated
Show resolved
Hide resolved
Error: /home/runner/work/rocketmq/rocketmq/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java:368:2: 'method def rcurly' has incorrect indentation level 1, expected level should be 4. [Indentation] |
Codecov Report
@@ Coverage Diff @@
## develop #5909 +/- ##
==========================================
Coverage 43.37% 43.37%
Complexity 8809 8809
==========================================
Files 1090 1090
Lines 76412 76409 -3
Branches 9981 9981
==========================================
+ Hits 33145 33146 +1
- Misses 39118 39128 +10
+ Partials 4149 4135 -14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuz10 @RongtongJin I also encountered this problem, but i don't recommend doing it through such an indirect way.
I perfer to redefine the compatible code directly.
such as:
public static final int POP_MESSAGE = 200050;
public static final int _POP_MESSAGE = 3442;
public static final int ACK_MESSAGE = 200051;
public static final int _ACK_MESSAGE = 3443;
...
@RongtongJin @echooymxq @HScarb Please review the code again. |
…eTypeCurrentRPC=ROCKETMQ fix code style detect occupied request code
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. |
This PR was closed because it has been inactive for 3 days since being marked as stale. |
Make sure set the target branch to
develop
What is the purpose of the change
#5684
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.