[ISSUE #8168] fix: There's no need to retry when async produce already timeout #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8169 +/- ##
=============================================
- Coverage 42.94% 42.87% -0.08%
+ Complexity 10376 10365 -11
=============================================
Files 1270 1270
Lines 88696 88697 +1
Branches 11402 11403 +1
=============================================
- Hits 38090 38025 -65
- Misses 45906 45967 +61
- Partials 4700 4705 +5 ☔ View full report in Codecov by Sentry. |
RongtongJin
reviewed
May 21, 2024
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
Outdated
Show resolved
Hide resolved
humkum
force-pushed
the
optimize-async-retry
branch
2 times, most recently
from
f44fb10 to
9d1d461
Compare
RongtongJin
previously approved these changes
May 21, 2024
|
PTAL～@guyinyou |
Willhow-Gao
suggested changes
May 21, 2024
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
Show resolved
Hide resolved
humkum
force-pushed
the
optimize-async-retry
branch
from
9d1d461 to
0468a09
Compare
Willhow-Gao
approved these changes
May 22, 2024
|
lgtm |
guyinyou
approved these changes
May 22, 2024
RongtongJin
approved these changes
May 22, 2024
cserwen
approved these changes
May 24, 2024
lizhimins
approved these changes
May 24, 2024
lizhimins
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8168