Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7853] Fix the manualDeleteFileSeveralTimes count #7855

Merged

Conversation

ChineseTony
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7853

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 42.94%. Comparing base (0b05e9c) to head (1bf1bc7).

Files Patch % Lines
...org/apache/rocketmq/store/DefaultMessageStore.java 71.42% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7855      +/-   ##
=============================================
- Coverage      42.94%   42.94%   -0.01%     
+ Complexity      9913     9910       -3     
=============================================
  Files           1190     1190              
  Lines          86014    86014              
  Branches       11079    11079              
=============================================
- Hits           36942    36939       -3     
+ Misses         44495    44492       -3     
- Partials        4577     4583       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leizhiyuan
Copy link
Contributor

you can modify the pr title

#7852

like [ISSUE #7852] Fix

@ChineseTony ChineseTony changed the title fix the manualDeleteFileSeveralTimes count [ISSUE #7853] fix the manualDeleteFileSeveralTimes count Feb 26, 2024
@ChineseTony ChineseTony changed the title [ISSUE #7853] fix the manualDeleteFileSeveralTimes count [ISSUE #7853] Fix the manualDeleteFileSeveralTimes count Feb 26, 2024
@RongtongJin RongtongJin merged commit 3877dcd into apache:develop Feb 29, 2024
9 of 10 checks passed
@ChineseTony ChineseTony deleted the fix_manual_delete_file_several_times branch March 3, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] manualDeleteFileSeveralTimes is not correct
6 participants