[ISSUE #7851] Fix hashcode and equals methods of SubscriptionGroupConfig #7852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leizhiyuan
reviewed
Feb 23, 2024
...rc/main/java/org/apache/rocketmq/remoting/protocol/subscription/SubscriptionGroupConfig.java
Outdated
Show resolved
Hide resolved
glcrazier
force-pushed
the
fix/subscription-hash-eq
branch
from
4cc9c1d to
104cb8a
Compare
RongtongJin
changed the title
RongtongJin
approved these changes
Feb 23, 2024
mxsm
approved these changes
Feb 23, 2024
yuz10
approved these changes
Feb 26, 2024
panzhi33
approved these changes
Feb 26, 2024
joeCarf
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7851
Brief Description
The
SubscriptionGroupConfig's equals and hashCode methods doesn't countconsumeMessageOrderlyfield in.How Did You Test This Change?