Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7626] Topic perm was mistakenly changed to 4 in dledger mode #7661

Merged
merged 3 commits into from
Dec 15, 2023
Merged

[ISSUE #7626] Topic perm was mistakenly changed to 4 in dledger mode #7661

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
584bba2
1、判断isPrimeSlave条件添加当前broker列表是否包含leader节点的判断
LittleBoy18 Dec 14, 2023
791fc4f
1、topic剔除写权限时，判断是否开启EnableActingMaster
LittleBoy18 Dec 15, 2023
e76d976
Update RouteInfoManager.java
LittleBoy18 Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ public RegisterBrokerResult registerBroker(
registerFirst = registerFirst || (StringUtils.isEmpty(oldAddr));

boolean isMaster = MixAll.MASTER_ID == brokerId;

boolean isPrimeSlave = !isOldVersionBroker && !isMaster
&& brokerId == Collections.min(brokerAddrsMap.keySet());

Expand All @@ -306,7 +307,8 @@ public RegisterBrokerResult registerBroker(
topicConfigWrapper.getDataVersion(), brokerName,
entry.getValue().getTopicName())) {
final TopicConfig topicConfig = entry.getValue();
if (isPrimeSlave) {
// In Slave Acting Master mode, Namesrv will regard the surviving Slave with the smallest brokerId as the "agent" Master, and modify the brokerPermission to read-only.
if (isPrimeSlave && brokerData.isEnableActingMaster()) {
// Wipe write perm for prime slave
topicConfig.setPerm(topicConfig.getPerm() & (~PermName.PERM_WRITE));
}
Expand Down
Loading