[ISSUE #7626] Topic perm was mistakenly changed to 4 in dledger mode #7661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
changed the title
RongtongJin
reviewed
Dec 15, 2023
| @@ -293,8 +293,10 @@ public RegisterBrokerResult registerBroker( | |||
| registerFirst = registerFirst || (StringUtils.isEmpty(oldAddr)); | |||
|
|
|||
| boolean isMaster = MixAll.MASTER_ID == brokerId; | |||
|
|
|||
| // isPrimeSlave < Slave Acting Master模式下，Namesrv将把brokerId最小的存活Slave视为“代理”Master，并将brokerPermission修改为4（Read-Only）> | |||
| boolean isPrimeSlave = !isOldVersionBroker && !isMaster | ||
| && brokerId == Collections.min(brokerAddrsMap.keySet()); | ||
| && brokerId == Collections.min(brokerAddrsMap.keySet()) && !brokerAddrsMap.containsKey(0L); |
There was a problem hiding this comment.
我觉得最好不要在这里修改，而是再擦除写权限的时候，看看是不是brokerData是不是打开enableActingMaster的
2、添加注释 Signed-off-by: littleboy <[email protected]>
RongtongJin
reviewed
Dec 15, 2023
Comment on lines
310
to
312
| if (isPrimeSlave) { | ||
| // Wipe write perm for prime slave | ||
| topicConfig.setPerm(topicConfig.getPerm() & (~PermName.PERM_WRITE)); | ||
| // In Slave Acting Master mode, Namesrv will regard the surviving Slave with the smallest brokerId as the "agent" Master, and modify the brokerPermission to read-only. | ||
| if (brokerData.isEnableActingMaster()){ |
RongtongJin
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、判断isPrimeSlave条件添加当前broker列表是否包含leader节点的判断
2、添加注释
Which Issue(s) This PR Fixes
Fixes #7626
Brief Description
How Did You Test This Change?