[pulsar-broker] cluster-resource use cluster name to fetch cluster-metadata #9928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
requested review from
merlimat,
sijie,
jiazhai,
codelipenghui and
murong00
rdhabalia
changed the title
eolivelli
approved these changes
Mar 16, 2021
| @@ -390,7 +391,7 @@ public void deleteCluster( | |||
| } | |||
| } catch (Exception e) { | |||
| log.error("[{}] Failed to get cluster usage {}", clientAppId(), cluster, e); | |||
| throw new RestException(e); | |||
| throw new RestException(e instanceof ExecutionException ? e.getCause() : e); | |||
There was a problem hiding this comment.
What about adding an utility function for this line? I see it written more times
|
/pulsarbot run-failure-checks |
315157973
reviewed
Mar 26, 2021
| } else { | ||
| log.error("[{}] Failed to get partitioned topic list for namespace {}", clientAppId(), | ||
| namespaceName.toString(), e); | ||
| throw new RestException(e); |
There was a problem hiding this comment.
Would it be better, just a suggestion
throw new RestException(e instanceof ExecutionException ? e.getCause() : e)
|
Hi Rajan @rdhabalia, Could you please help resolve the conflicts? so that we can merge it before 2.8.0 |
|
it seems #11693 again had same changes and that new PR is merged. so, we should close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Note: On top of : #9925
Cluster-resources should be able to fetch cluster-metadata and internal-path should be handled by the base-resources. It will make code clean and will be helpful for future abstraction.