Refactored PulsarResources to avoid building metadata paths everywhere #11693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
|
Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) |
|
sijie
approved these changes
Aug 21, 2021
eolivelli
approved these changes
Sep 4, 2021
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/ClusterResources.java
Outdated
Show resolved
Hide resolved
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/TopicResources.java
Outdated
Show resolved
Hide resolved
This was referenced Sep 29, 2021
1 task
1 task
codelipenghui
pushed a commit
that referenced
this pull request
Dec 28, 2021
### Motivation
This PR is used to keep same behavior with Pulsar 2.8 and 2.7 version.
In Pulsar 2.7 and 2.8, when delete a non-existent failure domain resource, it will return 404 status code.
In Pulsar 2.9, when delete a non-existent failure domain resource, it will return 200 status code.
Reproduce in Pulsar 2.8:
```
$ docker run -itd \
-p 6650:6650 \
-p 8080:8080 \
apachepulsar/pulsar:2.8.1 \
bin/pulsar standalone
$ pulsarctl clusters delete-failure-domain standalone non-existent-failure-domain
[✖] code: 404 reason: Domain-name non-existent-failure-domain or cluster standalone does not exist
```
Reproduce in Pulsar 2.9:
```
$ docker run -itd \
-p 6650:6650 \
-p 8080:8080 \
apachepulsar/pulsar:2.9.0 \
bin/pulsar standalone
$ pulsarctl clusters delete-failure-domain standalone non-existent-failure-domain
Delete failure domain [non-existent-failure-domain] for cluster [standalone] succeed
```
Affected version: 2.9.x
This issue was caused by #11693.
### Modifications
- Remove check resource exists when call the `ClusterResources#deleteFailureDomain()`
- Add check resource exists when call the `ClusterResources#deleteFailureDomains()`
codelipenghui
pushed a commit
that referenced
this pull request
Dec 30, 2021
### Motivation This PR is used to keep same behavior with Pulsar 2.8 and 2.7 version. In Pulsar 2.7 and 2.8, when delete a non-existent failure domain resource, it will return 404 status code. In Pulsar 2.9, when delete a non-existent failure domain resource, it will return 200 status code. Reproduce in Pulsar 2.8: ``` $ docker run -itd \ -p 6650:6650 \ -p 8080:8080 \ apachepulsar/pulsar:2.8.1 \ bin/pulsar standalone $ pulsarctl clusters delete-failure-domain standalone non-existent-failure-domain [✖] code: 404 reason: Domain-name non-existent-failure-domain or cluster standalone does not exist ``` Reproduce in Pulsar 2.9: ``` $ docker run -itd \ -p 6650:6650 \ -p 8080:8080 \ apachepulsar/pulsar:2.9.0 \ bin/pulsar standalone $ pulsarctl clusters delete-failure-domain standalone non-existent-failure-domain Delete failure domain [non-existent-failure-domain] for cluster [standalone] succeed ``` Affected version: 2.9.x This issue was caused by #11693. ### Modifications - Remove check resource exists when call the `ClusterResources#deleteFailureDomain()` - Add check resource exists when call the `ClusterResources#deleteFailureDomains()` (cherry picked from commit 7f4aac5)
wuzhanpeng
pushed a commit
to wuzhanpeng/pulsar
that referenced
this pull request
Jan 5, 2022
### Motivation
This PR is used to keep same behavior with Pulsar 2.8 and 2.7 version.
In Pulsar 2.7 and 2.8, when delete a non-existent failure domain resource, it will return 404 status code.
In Pulsar 2.9, when delete a non-existent failure domain resource, it will return 200 status code.
Reproduce in Pulsar 2.8:
```
$ docker run -itd \
-p 6650:6650 \
-p 8080:8080 \
apachepulsar/pulsar:2.8.1 \
bin/pulsar standalone
$ pulsarctl clusters delete-failure-domain standalone non-existent-failure-domain
[✖] code: 404 reason: Domain-name non-existent-failure-domain or cluster standalone does not exist
```
Reproduce in Pulsar 2.9:
```
$ docker run -itd \
-p 6650:6650 \
-p 8080:8080 \
apachepulsar/pulsar:2.9.0 \
bin/pulsar standalone
$ pulsarctl clusters delete-failure-domain standalone non-existent-failure-domain
Delete failure domain [non-existent-failure-domain] for cluster [standalone] succeed
```
Affected version: 2.9.x
This issue was caused by apache#11693.
### Modifications
- Remove check resource exists when call the `ClusterResources#deleteFailureDomain()`
- Add check resource exists when call the `ClusterResources#deleteFailureDomains()`
2 tasks
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
apache#11693) * Refactored PulsarResources to avoid building metadata paths everywhere * Fixed usages of ZkAdminPaths * Removed unused import * Fixed proxy * Fixed ResourceGroupServiceTest * Added MetadataStore deleteRecursive operation * Fixed merge issues * Use constant * Removed unused import * Fixes for ResourceGroupConfigListenerTest * Fixed cluster resources cleanup * Fixed topic list rest call * Fixed NPE in PersistentDispatcherFailoverConsumerTest setup * Fixed flaky test ReplicatorTest.testRemoveClusterFromNamespace * Fixed handling notification for V1 path namespaces * Fixed LocalPoliciesResources create * Fixed deadlock when making blocking calls from MetadataStore callback thread * Fixed usage of NamespaceName as key * Fixed missing mock in BacklogQuotaManagerConfigurationTest * Fixed RGUsageMTAggrWaitForAllMesgsTest * fixed ServerCnxTest * Fixed mock in PersistentSubscriptionTest * Fixed PersistentTopicTest * Fixed getting partitions list from NamespaceService * Fixed tenant not found expectation * Fixed ProxyConnection to check for existence of auth_data field
4 tasks
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
PulsarResourcesand its companion classes are all takingStrings with paths for resources in the metadata store. This has lead to a proliferation of string composition to construct these paths from all over the code base.Instead, we should be taking the resource namings (eg:
TopicName,NamespaceName, etc.) and hide the path in the metadata.Modifications
BaseResourcesto be protected