[improve] [broker] PIP-299-part-5: Add namespace-level policy: dispatcherPauseOnAckStatePersistent

[Technoboy-]

Motivation

The part 5 of PIP-299: the implementation of "Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled"

Related PRs:

• [improve] [broker] PIP-299-part-1: Stop dispatch messages if the individual acks will be lost in the persistent storage #21423
• [improve][broker] PIP-299-part-2: add config dispatcherPauseOnAckStatePersistentEnabled #21370
• [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled #21837
• [improve] [broker] PIP-299-part-4: Add topic-level policy: dispatcherPauseOnAckStatePersistent #21874
• part-5: Namespace level policies support
• part-6: Doc

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

[poorbarcode]

We can enable the case TypeOfUpdateTopicConfig.NAMESPACE_LEVEL_POLICY of the test testBrokerDynamicConfig now.

@DataProvider(name = "typesOfSetDispatcherPauseOnAckStatePersistent")
public Object[][] typesOfSetDispatcherPauseOnAckStatePersistent() {
    return new Object[][]{
      {TypeOfUpdateTopicConfig.BROKER_CONF},
      // {TypeOfUpdateTopicConfig.NAMESPACE_LEVEL_POLICY},
      {TypeOfUpdateTopicConfig.TOPIC_LEVEL_POLICY}
    };
}

[Technoboy-]

We can enable the case TypeOfUpdateTopicConfig.NAMESPACE_LEVEL_POLICY of the test testBrokerDynamicConfig now.

@DataProvider(name = "typesOfSetDispatcherPauseOnAckStatePersistent")
public Object[][] typesOfSetDispatcherPauseOnAckStatePersistent() {
    return new Object[][]{
      {TypeOfUpdateTopicConfig.BROKER_CONF},
      // {TypeOfUpdateTopicConfig.NAMESPACE_LEVEL_POLICY},
      {TypeOfUpdateTopicConfig.TOPIC_LEVEL_POLICY}
    };
}

Done

[codecov-commenter]

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (22838ea) 36.46% compared to head (1190461) 73.61%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #21926       +/-   ##
=============================================
+ Coverage     36.46%   73.61%   +37.14%     
- Complexity    12390    32422    +20032     
=============================================
  Files          1725     1861      +136     
  Lines        131701   138664     +6963     
  Branches      14401    15186      +785     
=============================================
+ Hits          48027   102072    +54045     
+ Misses        77254    28705    -48549     
- Partials       6420     7887     +1467     

Flag	Coverage Δ
inttests	24.10% <5.26%> (-0.01%)	⬇️
systests	23.60% <3.94%> (-0.07%)	⬇️
unittests	72.90% <85.52%> (+40.86%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...rg/apache/pulsar/broker/service/AbstractTopic.java	87.91% <100.00%> (+24.65%)	⬆️
...ava/org/apache/pulsar/client/admin/Namespaces.java	66.66% <ø> (+66.66%)	⬆️
...e/pulsar/client/admin/internal/NamespacesImpl.java	95.44% <100.00%> (+74.90%)	⬆️
...ava/org/apache/pulsar/admin/cli/CmdNamespaces.java	78.57% <100.00%> (+78.57%)	⬆️
...apache/pulsar/common/policies/data/PolicyName.java	100.00% <100.00%> (ø)
...che/pulsar/common/policies/data/TopicPolicies.java	58.73% <100.00%> (+6.34%)	⬆️
...pache/pulsar/broker/admin/impl/NamespacesBase.java	73.04% <81.81%> (+43.69%)	⬆️
...g/apache/pulsar/common/policies/data/Policies.java	57.14% <0.00%> (+3.80%)	⬆️
.../org/apache/pulsar/broker/admin/v2/Namespaces.java	69.09% <79.31%> (+52.59%)	⬆️

... and 1431 files with indirect coverage changes