-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled #21837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cherPauseOnAckStatePersistentEnabled
lhotari
reviewed
Jan 2, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Jan 2, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
...broker/src/test/java/org/apache/pulsar/client/api/SubscriptionPauseOnAckStatPersistTest.java
Show resolved
Hide resolved
...broker/src/test/java/org/apache/pulsar/client/api/SubscriptionPauseOnAckStatPersistTest.java
Show resolved
Hide resolved
Technoboy-
reviewed
Jan 3, 2024
.../java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
Outdated
Show resolved
Hide resolved
Technoboy-
reviewed
Jan 3, 2024
.../java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
Outdated
Show resolved
Hide resolved
codelipenghui
approved these changes
Jan 3, 2024
/pulsarbot run-failure-checks |
liangyepianzhou
approved these changes
Jan 4, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #21837 +/- ##
============================================
- Coverage 73.69% 73.58% -0.12%
+ Complexity 32352 32321 -31
============================================
Files 1858 1858
Lines 138144 138179 +35
Branches 15141 15148 +7
============================================
- Hits 101812 101681 -131
- Misses 28490 28625 +135
- Partials 7842 7873 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category/reliability
The function does not work properly in certain specific environments or failures. e.g. data lost
doc-not-needed
Your PR changes do not impact docs
ready-to-test
type/feature
The PR added a new feature or issue requested a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The part 3 of PIP-299: the implementation of "Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled"
Related PRs:
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x