Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled #21837

Merged
merged 7 commits into from
Jan 5, 2024

Conversation

poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Jan 2, 2024

The part 3 of PIP-299: the implementation of "Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled"

Related PRs:

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode self-assigned this Jan 2, 2024
@poorbarcode poorbarcode added this to the 3.3.0 milestone Jan 2, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 2, 2024
@poorbarcode poorbarcode added type/feature The PR added a new feature or issue requested a new feature category/reliability The function does not work properly in certain specific environments or failures. e.g. data lost labels Jan 2, 2024
@poorbarcode poorbarcode requested a review from lhotari January 2, 2024 16:34
@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@poorbarcode poorbarcode requested a review from Technoboy- January 4, 2024 07:31
@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (529e1ab) 73.69% compared to head (87dcc97) 73.58%.
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21837      +/-   ##
============================================
- Coverage     73.69%   73.58%   -0.12%     
+ Complexity    32352    32321      -31     
============================================
  Files          1858     1858              
  Lines        138144   138179      +35     
  Branches      15141    15148       +7     
============================================
- Hits         101812   101681     -131     
- Misses        28490    28625     +135     
- Partials       7842     7873      +31     
Flag Coverage Δ
inttests 24.18% <13.63%> (-0.07%) ⬇️
systests 23.84% <13.63%> (+0.06%) ⬆️
unittests 72.88% <81.81%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...org/apache/pulsar/broker/ServiceConfiguration.java 99.39% <100.00%> (+<0.01%) ⬆️
...rg/apache/pulsar/broker/service/AbstractTopic.java 88.01% <100.00%> (+0.23%) ⬆️
...rg/apache/pulsar/broker/service/BrokerService.java 81.19% <90.90%> (+0.05%) ⬆️
...a/org/apache/pulsar/broker/service/Dispatcher.java 55.00% <0.00%> (-2.90%) ⬇️
...sar/broker/service/persistent/PersistentTopic.java 78.43% <87.50%> (-0.26%) ⬇️
...sistent/PersistentDispatcherMultipleConsumers.java 74.16% <70.58%> (-0.80%) ⬇️

... and 75 files with indirect coverage changes

@Technoboy- Technoboy- merged commit 735c91a into apache:master Jan 5, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/reliability The function does not work properly in certain specific environments or failures. e.g. data lost doc-not-needed Your PR changes do not impact docs ready-to-test type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants