Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][client] Add explicit dependency on athenz-cert-refresher #19524

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

massakam
Copy link
Contributor

@massakam massakam commented Feb 15, 2023

Motivation

In #19445, I added import statements for the com.oath.auth.* classes to the AuthenticationAthenz class. These classes are in a package named athenz-cert-refresher, so we should add a dependency on this package. However, due to the indirect dependency, athenz-cert-refresher will be installed without doing this and the build will not fail.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@massakam massakam added type/bug The PR fixed a bug or issue reported a bug component/client-java doc-not-needed Your PR changes do not impact docs ready-to-test labels Feb 15, 2023
@massakam massakam added this to the 3.0.0 milestone Feb 15, 2023
@massakam massakam self-assigned this Feb 15, 2023
@massakam massakam force-pushed the add-athenz-cert-refresher branch from 4bc866c to c819ff6 Compare February 16, 2023 01:26
@codecov-commenter
Copy link

Codecov Report

Merging #19524 (c819ff6) into master (456d112) will increase coverage by 30.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #19524       +/-   ##
=============================================
+ Coverage     32.30%   62.31%   +30.01%     
+ Complexity     7103     3491     -3612     
=============================================
  Files          1670     1844      +174     
  Lines        125944   135266     +9322     
  Branches      13727    14870     +1143     
=============================================
+ Hits          40690    84296    +43606     
+ Misses        79263    43206    -36057     
- Partials       5991     7764     +1773     
Flag Coverage Δ
inttests 24.71% <33.33%> (+0.04%) ⬆️
systests 25.46% <20.00%> (+0.21%) ⬆️
unittests 59.56% <60.00%> (+39.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/apache/pulsar/broker/web/PulsarWebResource.java 57.98% <53.84%> (+24.54%) ⬆️
.../pulsar/client/impl/PulsarServiceNameResolver.java 89.74% <100.00%> (+10.25%) ⬆️
.../apache/pulsar/client/impl/ClientCnxIdleState.java 68.88% <0.00%> (-2.23%) ⬇️
...in/java/org/apache/pulsar/common/api/AuthData.java 71.42% <0.00%> (ø)
...ava/org/apache/pulsar/client/api/schema/Field.java 80.00% <0.00%> (ø)
.../apache/pulsar/broker/namespace/LookupOptions.java 87.50% <0.00%> (ø)
.../apache/pulsar/common/naming/SystemTopicNames.java 55.55% <0.00%> (ø)
...apache/pulsar/common/util/SafeCollectionUtils.java 0.00% <0.00%> (ø)
...org/apache/pulsar/common/io/BatchSourceConfig.java 50.00% <0.00%> (ø)
...pache/pulsar/common/configuration/BindAddress.java 22.22% <0.00%> (ø)
... and 1206 more

@nkurihar nkurihar merged commit 0e9935c into apache:master Feb 28, 2023
@massakam massakam deleted the add-athenz-cert-refresher branch February 28, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants