-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][client] AuthenticationAthenz supports Copper Argos #19445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19445 +/- ##
=============================================
+ Coverage 24.75% 63.83% +39.07%
- Complexity 288 3475 +3187
=============================================
Files 1579 1832 +253
Lines 121841 134145 +12304
Branches 13304 14760 +1456
=============================================
+ Hits 30164 85626 +55462
+ Misses 87240 40775 -46465
- Partials 4437 7744 +3307
Flags with carried forward coverage won't be shown. Click here to find out more.
|
735f848
to
29c19a0
Compare
merlimat
approved these changes
Feb 8, 2023
Hi @massakam, It will help users a lot if you can add the docs for this improvement. Do you have any planned updates on that? |
@momo-jun Yes, I will make a pull-request to the pulsar-site repository later. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc-complete
Your PR changes impact docs and the related docs have been already added.
ready-to-test
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Athenz has a mechanism called Copper Argos. This means that ZTS distributes an X.509 certificate and private key pair to each service, which it can use to identify itself to other services within the organization.
https://github.com/AthenZ/athenz/blob/master/docs/copper_argos.md
However, the current Pulsar's authentication plugin for Athenz cannot accept X.509 certificates as parameters, so we cannot use Copper Argos.
Modifications
Add the parameters
x509CertChain
andcaCert
to theAuthenticationAthenz
class of the Athenz authentication plugin. If an X.509 certificate is passed as a parameter, it assumes Copper Argos is used and instantiates anSSLContext
and creates aZTSClient
based on it. Existing users of this plugin will not be affected by this change.Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete