[improve][txn] PIP-160: Transaction buffered writer supports Timer #16727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
congbobo184
requested review from
codelipenghui,
congbobo184,
liangyepianzhou and
gaoran10
congbobo184
added
area/transaction
type/feature
|
/pulsarbot run-failure-checks |
...r/src/test/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriterTest.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriterTest.java
Outdated
Show resolved
Hide resolved
poorbarcode
changed the title
congbobo184
approved these changes
Jul 22, 2022
| @@ -73,15 +74,15 @@ | |||
|
|
|||
| private final ManagedLedger managedLedger; | |||
|
|
|||
| private final ScheduledExecutorService scheduledExecutorService; | |||
| private Timer timer; | |||
…eduledService and Timer
liangyepianzhou
approved these changes
Jul 24, 2022
congbobo184
approved these changes
Jul 25, 2022
codelipenghui
approved these changes
Jul 25, 2022
Technoboy-
approved these changes
Jul 25, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #15370
Motivation
see #15370
Modifications
In the original design of the transaction buffered writer, we use a scheduled executor to execute timed tasks. There are no scheduled executors that match this scenario, and It's a little expensive to have a new scheduled executor with 1 millis tick time.
The
PulsarService.brokerClientSharedTimeris very match to this scenario, so we should reuse it instead to create a new scheduled executor.So we should make transaction buffered writer supports
io.netty.Timer.Documentation
doc-requireddoc-not-neededdocdoc-complete