[improve][txn] PIP-160: Pending ack log store enables the batch feature #16707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
force-pushed
the
pip/160-9
branch
2 times, most recently
from
3630888 to
24375a5
Compare
congbobo184
requested review from
liangyepianzhou,
codelipenghui,
congbobo184 and
gaoran10
congbobo184
added
area/transaction
type/feature
congbobo184
reviewed
Jul 21, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
congbobo184
reviewed
Jul 21, 2022
...er/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
@poorbarcode #16727 has merged, could you please use the shared time for this PR? |
Already fixed. |
codelipenghui
approved these changes
Jul 26, 2022
Comment on lines
227
to
228
| @Getter | ||
| private final ScheduledExecutorService transactionTimer; |
Comment on lines
350
to
351
| this.transactionTimer = Executors | ||
| .newSingleThreadScheduledExecutor(new DefaultThreadFactory("pulsar-backlog-quota-checker")); |
There was a problem hiding this comment.
Already remove. Thanks.
| buffer.resetReaderIndex(); | ||
| if (magicNum == BATCHED_ENTRY_DATA_PREFIX_MAGIC_NUMBER){ | ||
| // skip version | ||
| buffer.skipBytes(4); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Already fixed. Thanks.
| } | ||
| }).when(pendingAckHandle).completeHandleFuture(); | ||
| mlPendingAckStoreForRead.replayAsync(pendingAckHandle, internalPinnedExecutor); | ||
| Awaitility.await().atMost(200, TimeUnit.SECONDS).until(() -> processController.get() == 1); |
There was a problem hiding this comment.
Why need to wait at most 200 seconds? we don't have too many logs in the pending ack store.
There was a problem hiding this comment.
Already change to 2 seconds.
congbobo184
approved these changes
Jul 26, 2022
codelipenghui
approved these changes
Jul 26, 2022
|
/pulsarbot rerun-failure-checks |
1 similar comment
|
/pulsarbot rerun-failure-checks |
Gleiphir2769
pushed a commit
to Gleiphir2769/pulsar
that referenced
this pull request
Aug 4, 2022
…re (apache#16707) Master Issue: apache#15370 ### Motivation see apache#15370 ### Modifications I will complete proposal apache#15370 with these pull requests( *current pull request is the step-4* ): 1. Write the batch transaction log handler: `TxnLogBufferedWriter` 2. Configuration changes and protocol changes. 3. Transaction log store enables the batch feature. 4. Pending ack log store enables the batch feature. 5. Supports dynamic configuration. 6. Append admin API for transaction batch log and docs( admin and configuration doc ). 7. Append metrics support for transaction batch log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #15370
Motivation
see #15370
Modifications
I will complete proposal #15370 with these pull requests( current pull request is the step-4 ):
TxnLogBufferedWriterDocumentation
doc-requireddoc-not-neededdocdoc-complete