-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add current ip address, long hostname and short hostname to /etc/hosts #10233
[CI] Add current ip address, long hostname and short hostname to /etc/hosts #10233
Conversation
@lhotari good catch ! do you have any link to other projects that have similar problems and their solutions ? |
Not yet, I was about to look around. I'll also notify other Apache projects on [email protected] mailing list soon. |
My assumption is that something broke when GitHub added some protection against Bitcoin miners. Here's the /etc/hosts file from a Runner VM with entries against miners: https://gist.github.com/lhotari/1a027ee2eb3eee45739650d7ffe01860 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the explanation
LGTM
@merlimat @eolivelli @aahmed-se @sijie please merge this asap to unblock CI |
…ostname to /etc/hosts <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> Fixes reverse DNS lookup for the current hostname. This makes GitHub Actions flacky currently. ```scala DDLTPCDSSuite: *** RUN ABORTED *** java.net.BindException: Cannot assign requested address at sun.nio.ch.Net.bind0(Native Method) at sun.nio.ch.Net.bind(Net.java:461) at sun.nio.ch.Net.bind(Net.java:453) at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:222) at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:85) at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:78) at org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:90) at org.apache.kyuubi.zookeeper.EmbeddedZookeeper.initialize(EmbeddedZookeeper.scala:53) at org.apache.kyuubi.WithKyuubiServer.beforeAll(WithKyuubiServer.scala:48) at org.apache.kyuubi.WithKyuubiServer.beforeAll$(WithKyuubiServer.scala:38) ``` See apache/pulsar#10232 and apache/pulsar#10233 for more details. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #1735 from yaooqinn/ci. Closes #1735 03e9f51 [Kent Yao] [CI] Add current ip address, long hostname and short hostname to /etc/hosts 7503db7 [Kent Yao] Merge branch 'master' into ci b3b6d8b [Kent Yao] [CI] Add current ip address, long hostname and short hostname to /etc/hosts Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
Fixes #10232
Motivation
The reverse lookup for the current hostname is broken in GitHub Actions Runner VMs.
Modifications
Add the current IP address, long hostname and short hostname record to /etc/hosts file at the beginning of each GitHub Actions workflow.