Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add current ip address, long hostname and short hostname to /etc/hosts #1735

Closed
wants to merge 3 commits into from

Conversation

yaooqinn
Copy link
Member

Why are the changes needed?

Fixes reverse DNS lookup for the current hostname. This makes GitHub Actions flacky currently.

DDLTPCDSSuite:
*** RUN ABORTED ***
  java.net.BindException: Cannot assign requested address
  at sun.nio.ch.Net.bind0(Native Method)
  at sun.nio.ch.Net.bind(Net.java:461)
  at sun.nio.ch.Net.bind(Net.java:453)
  at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:222)
  at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:85)
  at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:78)
  at org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:90)
  at org.apache.kyuubi.zookeeper.EmbeddedZookeeper.initialize(EmbeddedZookeeper.scala:53)
  at org.apache.kyuubi.WithKyuubiServer.beforeAll(WithKyuubiServer.scala:48)
  at org.apache.kyuubi.WithKyuubiServer.beforeAll$(WithKyuubiServer.scala:38)

See apache/pulsar#10232 and apache/pulsar#10233 for more details.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@yaooqinn yaooqinn closed this Jan 12, 2022
@yaooqinn yaooqinn reopened this Jan 12, 2022
@yaooqinn yaooqinn closed this Jan 12, 2022
@yaooqinn yaooqinn reopened this Jan 12, 2022
@yaooqinn yaooqinn self-assigned this Jan 12, 2022
@yaooqinn yaooqinn added this to the v1.5.0 milestone Jan 12, 2022
@yaooqinn
Copy link
Member Author

@codecov-commenter
Copy link

Codecov Report

Merging #1735 (03e9f51) into master (8846377) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1735      +/-   ##
============================================
+ Coverage     59.51%   59.53%   +0.02%     
- Complexity      233      234       +1     
============================================
  Files           268      268              
  Lines         13305    13305              
  Branches       1688     1688              
============================================
+ Hits           7918     7921       +3     
+ Misses         4709     4708       -1     
+ Partials        678      676       -2     
Impacted Files Coverage Δ
...rg/apache/kyuubi/engine/trino/TrinoStatement.scala 65.47% <0.00%> (+1.19%) ⬆️
...he/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala 93.44% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8846377...03e9f51. Read the comment docs.

@yaooqinn yaooqinn added the infra label Jan 12, 2022
@yaooqinn yaooqinn closed this in 77f8604 Jan 12, 2022
@yaooqinn yaooqinn deleted the ci branch January 12, 2022 05:24
@yaooqinn
Copy link
Member Author

thanks, merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants