Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client memory limits docs. #571

Merged
merged 2 commits into from
May 15, 2023
Merged

Conversation

shibd
Copy link
Member

@shibd shibd commented May 11, 2023

Preview

image image

Relation PR

This PR adds doc for apache/pulsar-client-go#991 (comment)

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@shibd shibd self-assigned this May 11, 2023
@github-actions github-actions bot added the doc Improvements or additions to documentation label May 11, 2023
Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you attach the related code PR in the doc PR description (as commented in #565 (comment))? So that reviewers will have more context, which can speed up the review process.

docs/client-libraries-clients.md Outdated Show resolved Hide resolved
docs/client-libraries-clients.md Outdated Show resolved Hide resolved
@Anonymitaet
Copy link
Member

This PR adds doc for apache/pulsar-client-go#991 (comment)

@shibd
Copy link
Member Author

shibd commented May 12, 2023

Can you attach the related code PR in the doc PR description (as commented in #565 (comment))? So that reviewers will have more context, which can speed up the review process.

oh, Sorry. Maybe we can change PR template?

Preview

Relation PR

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@shibd shibd requested a review from Anonymitaet May 12, 2023 02:15
@Anonymitaet
Copy link
Member

Can you attach the related code PR in the doc PR description (as commented in #565 (comment))? So that reviewers will have more context, which can speed up the review process.

oh, Sorry. Maybe we can change PR template?

Preview

Relation PR

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Sure, done in #572

@Anonymitaet Anonymitaet added this to the 3.0.0 milestone May 15, 2023
@Anonymitaet Anonymitaet merged commit c6e20d6 into apache:main May 15, 2023
@Technoboy- Technoboy- mentioned this pull request Aug 9, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants