Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CPP client table view doc. #565

Merged
merged 4 commits into from
May 22, 2023
Merged

Add CPP client table view doc. #565

merged 4 commits into from
May 22, 2023

Conversation

shibd
Copy link
Member

@shibd shibd commented May 9, 2023

Preview

image

image

image

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@shibd shibd requested review from tisonkun, Anonymitaet and momo-jun May 9, 2023 08:11
@shibd shibd self-assigned this May 9, 2023
@github-actions github-actions bot added the doc Improvements or additions to documentation label May 9, 2023
@Anonymitaet
Copy link
Member

Anonymitaet commented May 10, 2023 •
edited
Loading

Thanks for your contribution!

  1. This PR ignores the 1st task in [TableView-2] Implement all interfaces. pulsar-client-cpp#196 (comment) as we discussed before, any thoughts?

  2. Can you attach the related code PR in the doc PR description? So that reviewers will have more context, which can speed up the review process.

Anonymitaet
Anonymitaet reviewed May 10, 2023
View reviewed changes
docs/client-libraries-tableviews.md Show resolved Hide resolved
docs/client-libraries-tableviews.md Outdated Show resolved Hide resolved
docs/client-libraries-tableviews.md Show resolved Hide resolved
docs/client-libraries-tableviews.md Outdated Show resolved Hide resolved
docs/client-libraries-tableviews.md Outdated Show resolved Hide resolved
docs/client-libraries-tableviews.md Outdated Show resolved Hide resolved
docs/client-libraries-tableviews.md Outdated Show resolved Hide resolved
docs/client-libraries-tableviews.md Outdated Show resolved Hide resolved
@Anonymitaet Anonymitaet mentioned this pull request May 12, 2023
Merged
4 tasks
@Anonymitaet Anonymitaet added this to the 3.1.0 milestone May 12, 2023
@Anonymitaet
Copy link
Member

Anonymitaet commented May 12, 2023 •
edited
Loading

Thanks for your contribution!

  1. This PR ignores the 1st task in [TableView-2] Implement all interfaces. pulsar-client-cpp#196 (comment) as we discussed before, any thoughts?
  2. Can you attach the related code PR in the doc PR description? So that reviewers will have more context, which can speed up the review process.

Confirmed with @shibd, the 1st task can be skipped as compaction topics are enabled in TableView internally by default, and it is explained in https://pulsar.apache.org/docs/next/concepts-clients/#tableview

@shibd shibd requested review from Anonymitaet and momo-jun May 16, 2023 02:33
@shibd shibd merged commit 9bfa32e into apache:main May 22, 2023
@Technoboy- Technoboy- mentioned this pull request Aug 9, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@Anonymitaet Anonymitaet Anonymitaet approved these changes

@momo-jun momo-jun Awaiting requested review from momo-jun

Assignees

@shibd shibd

Labels
doc Improvements or additions to documentation
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shibd @Anonymitaet @tisonkun @momo-jun