track progress from within segment processor framework #9457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
e.g. for those progress status from SegmentProcessorFramework: |
klsince
force-pushed
the
track_progress_in_segment_processor_framework
branch
from
dba00aa to
4143030
Compare
klsince
commented
Sep 23, 2022
| } catch (Exception e) { | ||
| _eventObserver.notifyTaskError(pinotTaskConfig, e); | ||
| _minionMetrics.addMeteredTableValue(taskType, MinionMeter.NUMBER_TASKS_FAILED, 1L); | ||
| LOGGER.error("Caught exception while executing task: {}", _taskConfig.getId(), e); | ||
| return new TaskResult(TaskResult.Status.FAILED, e.toString()); | ||
| return new TaskResult(TaskResult.Status.FAILED, StringUtil.getStackTraceAsString(e)); |
There was a problem hiding this comment.
e.toString() like e.getMessage() just returns the error msg (basically the first line of the stack trace).
klsince
force-pushed
the
track_progress_in_segment_processor_framework
branch
from
4143030 to
1474e92
Compare
and keep full exception stack trace instead of the top line in task info field
klsince
force-pushed
the
track_progress_in_segment_processor_framework
branch
from
1474e92 to
d28ab78
Compare
zhtaoxiang
reviewed
Sep 26, 2022
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/mapper/SegmentMapper.java
Outdated
Show resolved
Hide resolved
klsince
force-pushed
the
track_progress_in_segment_processor_framework
branch
from
0bd1905 to
178eaa2
Compare
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
* track progress from within segment processor framework and keep full exception stack trace instead of the top line in task info field * cr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #9449 to get finer grained progress status from SegmentProcessorFramework as well, as that's usually the step takes most of task time, breaking it down to map/reduce/generation steps for now.