refine minion worker event observer to track finer grained progress for tasks #9449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klsince
force-pushed
the
refine_task_progress_observer
branch
from
d0339eb to
eeefc0c
Compare
zhtaoxiang
reviewed
Sep 22, 2022
...roller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java
Show resolved
Hide resolved
...c/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java
Show resolved
Hide resolved
pinot-minion/src/main/java/org/apache/pinot/minion/api/resources/PinotTaskProgressResource.java
Show resolved
Hide resolved
...not/plugin/minion/tasks/realtimetoofflinesegments/RealtimeToOfflineSegmentsTaskExecutor.java
Show resolved
Hide resolved
.../src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskExecutor.java
Show resolved
Hide resolved
pinot-minion/src/main/java/org/apache/pinot/minion/event/MinionProgressObserver.java
Show resolved
Hide resolved
pinot-minion/src/main/java/org/apache/pinot/minion/event/MinionProgressObserver.java
Show resolved
Hide resolved
pinot-minion/src/main/java/org/apache/pinot/minion/event/MinionProgressObserver.java
Show resolved
Hide resolved
pinot-minion/src/main/java/org/apache/pinot/minion/event/MinionProgressObserver.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #9449 +/- ##
============================================
- Coverage 69.85% 63.61% -6.25%
+ Complexity 5098 5078 -20
============================================
Files 1902 1854 -48
Lines 101517 99349 -2168
Branches 15411 15159 -252
============================================
- Hits 70917 63202 -7715
- Misses 25596 31497 +5901
+ Partials 5004 4650 -354
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhtaoxiang
reviewed
Sep 22, 2022
...inot/plugin/minion/tasks/converttorawindex/ConvertToRowIndexTaskProgressObserverFactory.java
Outdated
Show resolved
Hide resolved
klsince
force-pushed
the
refine_task_progress_observer
branch
from
4df2308 to
ba9cebe
Compare
klsince
force-pushed
the
refine_task_progress_observer
branch
from
ba9cebe to
de381c6
Compare
jackjlli
approved these changes
Sep 23, 2022
...c/main/java/org/apache/pinot/plugin/minion/tasks/BaseMultipleSegmentsConversionExecutor.java
Outdated
Show resolved
Hide resolved
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
…or tasks (apache#9449) * refine minion worker event observer to track finer grained progress for tasks * cr * cr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds upon the last one #9432 to track finer grained task progress for current minion task types, and has refined the progress observer to keep last N status to be more informative.