[multistage] add calcite function catalog #9375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterddr
commented
Sep 10, 2022
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #9375 +/- ##
============================================
+ Coverage 69.70% 69.80% +0.09%
- Complexity 4786 5094 +308
============================================
Files 1885 1885
Lines 100377 100387 +10
Branches 15275 15276 +1
============================================
+ Hits 69972 70079 +107
+ Misses 25454 25357 -97
Partials 4951 4951
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Does it handle the case if a function is overloaded? |
the limitation is still the same as current behavior
|
walterddr
force-pushed
the
pr_add_function_catalog
branch
from
fd59bfe to
9b95e89
Compare
walterddr
force-pushed
the
pr_add_function_catalog
branch
from
9b95e89 to
6556553
Compare
31 tasks
mayankshriv
approved these changes
Sep 12, 2022
| @@ -86,6 +96,11 @@ public static void init() { | |||
| */ | |||
| public static void registerFunction(Method method, boolean nullableParameters) { | |||
| registerFunction(method.getName(), method, nullableParameters); | |||
|
|
|||
| // Calcite ScalarFunctionImpl doesn't allow customized named functions. TODO: fix me. | |||
There was a problem hiding this comment.
we will need to follow up items in #8597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FunctionRegistry currently hosts lots of scalar functions. there are not registered with the Calcite catalog reader.
this PR registers
TODO