-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[multistage] Support IN and NOT-IN Clauses #9374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add some test to validate this?
this should be included in #9375 |
@walterddr : I was working on the IN/NOT-IN/Range support. Does #9375 take care of that as well? |
Codecov Report
@@ Coverage Diff @@
## master #9374 +/- ##
============================================
+ Coverage 63.40% 68.49% +5.08%
- Complexity 4762 4780 +18
============================================
Files 1832 1886 +54
Lines 98146 100428 +2282
Branches 15020 15282 +262
============================================
+ Hits 62231 68786 +6555
+ Misses 31321 26701 -4620
- Partials 4594 4941 +347
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ah. no that only takes care of the could you add some test cases to validate your change for IN as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me overall with the approach. left a few comments. plz kindly take a look
Related to #9345
Query to verify:
cc: @walterddr