Adding Pinot base build/runtime image support for Amazon Corretto and MS OpenJDK #10422
Conversation
|
Thanks @xiangfu0 Are we going to end creating images for oracle openjdk ? |
I plan to switch the default to amazon jdk then also publish ms-openjdk image. |
I see Thanks for working on this |
|
Looks good to me |
Codecov Report
@@ Coverage Diff @@
## master #10422 +/- ##
============================================
- Coverage 70.26% 64.21% -6.05%
- Complexity 5269 6082 +813
============================================
Files 2049 1999 -50
Lines 111068 108935 -2133
Branches 16898 16646 -252
============================================
- Hits 78045 69956 -8089
- Misses 27554 33888 +6334
+ Partials 5469 5091 -378
Flags with carried forward coverage won't be shown. Click here to find out more. see 525 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| ```SHELL | ||
| docker build -t apachepinot/pinot-base-runtime:openjdk11-arm64v8 --platform linux/arm64 --no-cache --network=host --build-arg JAVA_VERSION=11 --build-arg OPENJDK_IMAGE=arm64v8/openjdk -f pinot-base-runtime/Dockerfile . | ||
| docker buildx build --no-cache --platform=linux/arm64,linux/amd64 --file pinot-base-build/amazoncorretto.dockerfile --tag apachepinot/pinot-base-build:11-ms-openjdk --push . |
There was a problem hiding this comment.
Is this a typo? I would expect that for MS OpenJDK we should use ms-openjdk.dockerfile as base image.
| # fontconfig. The folks who manage the docker hub's | ||
| # official image library have found that font management | ||
| # is a common usecase, and painpoint, and have | ||
| # recommended that Java images include font support. |
There was a problem hiding this comment.
Why don't we install the same in ms or openjdk versions?
| # | ||
| ARG JAVA_VERSION=11 | ||
| ARG JDK_IMAGE=mcr.microsoft.com/openjdk/jdk | ||
| FROM ${JDK_IMAGE}:${JAVA_VERSION}-ubuntu AS pinot_build_env |
There was a problem hiding this comment.
ms-openjdk.dockerfile and openjdk.dockerfile are just the same except for these two lines:
ARG JDK_IMAGE=openjdk
FROM ${JDK_IMAGE}:${JAVA_VERSION} AS pinot_build_env
ARG JDK_IMAGE=mcr.microsoft.com/openjdk/jdk
FROM ${JDK_IMAGE}:${JAVA_VERSION}-ubuntu AS pinot_build_env
The differences with amazoncoretto.dockerfile are not that large if we also include fontconfig. Shouldn't be enough to have a single dockerfile base image (same with runtime) where FROM is build from docker args?
| ARG JAVA_VERSION=11 | ||
| ARG JDK_IMAGE=amazoncorretto | ||
|
|
||
| FROM ${JDK_IMAGE}:${JAVA_VERSION}-al2-jdk |
There was a problem hiding this comment.
This is the only image that doesn't derive from ubuntu. I don't mind to use alpine images (although I've never like the hype on alpine docker images, the base image should be cached in the node anyway), but having to choose between alpine or ubuntu depending on the vendor doesn't sound good.
I mean, I would prefer to have a dockerfile for ubuntu, a dockerfile for alpine and choose the meta-base (either corretto, ms or whatever) based on docker ARGs. Otherwise we will see a combinatorial explosion of different dockerfiles depending on the openjdk distribution and the linux distribution
|
Thanks for the quick work @xiangfu0 .Just curious does the latest-11-amazoncorretto point to 0.12.1 |
Make Pinot base build and runtime images support Amazon Corretto and MS OpenJDK