Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for AWS Corretto and Microsoft JDK 11 #10274

Closed
abhijeetkushe opened this issue Feb 13, 2023 · 8 comments
Closed

Provide support for AWS Corretto and Microsoft JDK 11 #10274

abhijeetkushe opened this issue Feb 13, 2023 · 8 comments

Comments

@abhijeetkushe
Copy link
Contributor

Current Docker image of Pinot is built on OpenDJK 11.Open JDK 11 will end the active support from September 30. Please see https://endoflife.date/java
Screen Shot 2023-02-13 at 11 19 57 AM

Can Pinot start pushing official images for AWS corretto 11 and Microsoft JDK 11 for EKS on AWS or Azure users ?

@Jackie-Jiang
Copy link
Contributor

cc @xiangfu0

@abhijeetkushe
Copy link
Contributor Author

Any updates on this ?

@abhijeetkushe
Copy link
Contributor Author

abhijeetkushe commented Mar 14, 2023

@xiangfu0 Our org does need to build a corretto imageJust wanted to see if I can help with story
Looking at the README it looks like existing dockerfile already supports modifying the Java distribution
https://github.com/apache/pinot/tree/master/docker/images/pinot-base .If it is the case will i work if we just add another task for Corretto by passing env arg OPENJDK_IMAGE to amazoncorretto. Or do you think we might need a new DockerFile
https://github.com/apache/pinot/blob/master/.github/workflows/build-pinot-docker-image.yml#L59-L67
cc @mayankshriv

@xiangfu0
Copy link
Contributor

#10422

@abhijeetkushe
Copy link
Contributor Author

Closing issue as #10422 covers this

@xiangfu0
Copy link
Contributor

#10429

@abhijeetkushe
Copy link
Contributor Author

@xiangfu0 I had opened a issue on bitnami for supporting corretto but they decided to not include that in their plans.So we might have to create a custom zookeeper with corretto
bitnami/containers#27515 (comment)

@abhijeetkushe abhijeetkushe reopened this Mar 17, 2023
@xiangfu0
Copy link
Contributor

xiangfu0 commented Apr 2, 2023

@xiangfu0 I had opened a issue on bitnami for supporting corretto but they decided to not include that in their plans.So we might have to create a custom zookeeper with corretto bitnami/containers#27515 (comment)

I believe this should still go with Zookeeper community to support the docker image to avoid the potential divergence.

Both bitnami and Pinot are the consumer of the Zookeeper docker image.

If your project has strict requirements on the JDK distribution, I would suggest to build the docker image by your self then wait for the response from the community.

@xiangfu0 xiangfu0 closed this as completed Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants