-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-3007: Ensure version specific Jackson classes are shaded #3017
Conversation
@z-anderson, could you add a comment here referencing your modification so we won't forget to update the shaded versions if needed? |
@z-anderson, I've ment adding a comment in the master pom where |
This reverts commit 3821b53.
@gszadovszky Thank you! This is still blocking us. Are you able to release it soon please? |
Sorry @z-anderson, I don't have time to guide a release. As @wgtmac suggested at the other PR, it should be discussed on the dev list. |
@gszadovszky @wgtmac @Fokko My emails are seemingly not making it through to the dev mailing list. This is really a big problem for us in Spark. Do you know why I am having trouble/does anyone have the bandwidth to help me out? |
I have seen duplicate emails on the dev list. No worries, I can help with the release and just replied to the email you have sent. |
Rationale for this change
The current jar contains version specific classes under META-INF/versions/... with unshaded package names. This leads to clashes with jackson and thus classpath duplicates. This is a major problem in many big projects right now (e.g. Spark).
What changes are included in this PR?
Ensure these classes are shaded.
Are these changes tested?
Are there any user-facing changes?
Closes #3007