-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-3007: Ensure version specific Jackson classes are shaded #3008
Conversation
cc @wgtmac hey this is a pretty big issue for us. It is preventing us from taking other fixes. There might be a smarter way to do this but just wanted to kick this off - thanks 😄 |
@gszadovszky @Fokko Could you please help review this? Thanks! |
@ted-jenks, have you tried this one? |
@gszadovszky I agree having the automation would be much better, but I cannot get that to work. When using |
Would it be possible to get a minor release of this? It is kinda dangerous to use the current release with anything that has a different jackson version. |
@gszadovszky @Fokko @wgtmac any updates on this? sorry for pushing it is just blocking us taking some fixes right now. |
@gszadovszky @Fokko @wgtmac 🙏🏻 would be super helpful to get this through |
Sorry, @ted-jenks, I was on vacation. I've quickly checked the content of the jenkins jars on my local maven repo and found the following versions in |
@gszadovszky Thank you, I addressed your comment. (I work with Ted). #3017 . This is blocking us |
<shadedPattern>META-INF.versions.17.${shade.prefix}.${jackson.package}</shadedPattern> | ||
</relocation> | ||
<relocation> | ||
<pattern>META-INF.versions.21.${jackson.package}</pattern> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we pick up only 11/17/21 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the new PR #3017, we pick up 9/11/17/19/21
For the next release, I think we can discuss on the dev@parquet ML. It may be the time to directly release 1.15.0 instead of 1.14.x |
@z-anderson, shall we close this PR in favor of #3017, then? |
|
Closing this one in favor of #3017 |
Rationale for this change
The current jar contains version specific classes under META-INF/versions/... with unshaded package names. This leads to clashes with jackson and thus classpath duplicates. This is a major problem in many big projects right now (e.g. Spark).
What changes are included in this PR?
Ensure these classes are shaded.
Are these changes tested?
Are there any user-facing changes?
Closes #3007