ORC-1685: Use Pattern Matching for instanceof in RecordReaderImpl
#1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Thank you, @cxzl25 . Could you find more like the previous PR?
|
Merged to main for Apache ORC 2.1. Thank you, @cxzl25 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use Java 16
Pattern Matching for instanceof(JEP-394) syntax inRecordReaderImpl.Why are the changes needed?
Since Apache ORC 2.0 supports Java 17+, we can take advantage of this new syntax.
How was this patch tested?
GA
Was this patch authored or co-authored using generative AI tooling?
No