Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rest-assured to v4.0.0 #4500

Merged
merged 2 commits into from
May 31, 2019

Conversation

chetanmeh
Copy link
Member

Updates rest-assured library to v4.0.0 from v2.6.0 to enable execution on JDK 11

Description

Some of the tests were failing on JDK 11 which requires updating the rest-assured library to v4.0.0 as that has support for jdk 11

This PR is part of work being done under #4217 to enable JDK 11 support

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markusthoemmes markusthoemmes merged commit aeabc35 into apache:master May 31, 2019
BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
* Update to restassured v4.0 which is compatible with jdk11

* Need to initialize both truststore and keystore for ssl cert to be validated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants